Issue 204343002: HTMLOListElement::updateListItem should update distribution if needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204343002: HTMLOListElement::updateListItem should update distribution if needed. (Closed)

Created:
6 years, 9 months ago by tasak

Modified:
6 years, 9 months ago

Reviewers:
tkent, esprehn, dglazkov

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

HTMLOListElement::updateListItem should update distribution if needed. BUG=353233 TEST=fast/dom/shadow/ol-with-distribution-recalc-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169615

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -0 lines)			Patch
A	LayoutTests/fast/dom/shadow/ol-with-distribution-recalc-crash.html	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/shadow/ol-with-distribution-recalc-crash-expected.html	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLOListElement.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

esprehn

We should put the ASSERT(!current->document().childNeedsDistributionRecalc()); inside NodeRenderingTraversal:: parent/next/previous. They shouldn't be inside RenderListItem. lgtm though, ...

6 years, 9 months ago (2014-03-19 10:50:46 UTC) #2

tasak

Thank you for reviewing. Sure. I will create another patch for moving the ASSERT.

6 years, 9 months ago (2014-03-20 04:44:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/204343002/1

6 years, 9 months ago (2014-03-20 04:44:51 UTC) #5

Message was sent while issue was closed.

Change committed as 169615

Expand Messages | Collapse Messages