Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: server/auth/signing/context.go

Issue 2043423004: Make HTTP middleware easier to use (Closed) Base URL: https://github.com/luci/luci-go@master
Patch Set: Update tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: server/auth/signing/context.go
diff --git a/server/auth/signing/context.go b/server/auth/signing/context.go
index 9cb0f6ae8a28d840fcb7f24af9a5cd641365f39d..0c689a3c9182c36fcc3143e250aeb36582b44306 100644
--- a/server/auth/signing/context.go
+++ b/server/auth/signing/context.go
@@ -10,10 +10,9 @@ import (
"fmt"
"net/http"
- "github.com/julienschmidt/httprouter"
"golang.org/x/net/context"
- "github.com/luci/luci-go/server/middleware"
+ "github.com/luci/luci-go/server/router"
)
type contextKey int
@@ -43,16 +42,16 @@ func SignBytes(c context.Context, blob []byte) (keyName string, signature []byte
// InstallHandlers installs a handler that serves public certificates provided
// by the signer inside the base context. FetchCertificates is hitting this
// handler.
-func InstallHandlers(r *httprouter.Router, base middleware.Base) {
- r.GET("/auth/api/v1/server/certificates", base(certsHandler))
+func InstallHandlers(r *router.Router, handlers []router.Handler) {
+ r.GET("/auth/api/v1/server/certificates", append(handlers, certsHandler)...)
}
// certsHandler servers public certificates of the signer in the context.
-func certsHandler(c context.Context, rw http.ResponseWriter, r *http.Request, p httprouter.Params) {
+func certsHandler(c *router.Context) {
reply := func(code int, out interface{}) {
- rw.Header().Set("Content-Type", "application/json")
- rw.WriteHeader(code)
- json.NewEncoder(rw).Encode(out)
+ c.Writer.Header().Set("Content-Type", "application/json")
+ c.Writer.WriteHeader(code)
+ json.NewEncoder(c.Writer).Encode(out)
}
replyError := func(code int, msg string) {
@@ -62,16 +61,19 @@ func certsHandler(c context.Context, rw http.ResponseWriter, r *http.Request, p
reply(code, &errorReply)
}
- s := GetSigner(c)
+ s := GetSigner(c.Context)
if s == nil {
replyError(http.StatusNotFound, "No Signer instance available")
+ c.Abort()
return
}
- certs, err := s.Certificates(c)
+ certs, err := s.Certificates(c.Context)
if err != nil {
replyError(http.StatusInternalServerError, fmt.Sprintf("Can't fetch certificates - %s", err))
- } else {
- reply(http.StatusOK, certs)
+ c.Abort()
+ return
}
+
+ reply(http.StatusOK, certs)
}

Powered by Google App Engine
This is Rietveld 408576698