Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: server/auth/info/info.go

Issue 2043423004: Make HTTP middleware easier to use (Closed) Base URL: https://github.com/luci/luci-go@master
Patch Set: Update tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: server/auth/info/info.go
diff --git a/server/auth/info/info.go b/server/auth/info/info.go
index f03abdcc8ba4bbf2794b519ff0ec56ad8260033e..9a44c2fc8f70655ccf9c26937fa426f4644f85b3 100644
--- a/server/auth/info/info.go
+++ b/server/auth/info/info.go
@@ -13,12 +13,11 @@ import (
"net/http"
"time"
- "github.com/julienschmidt/httprouter"
"golang.org/x/net/context"
"github.com/luci/luci-go/server/auth/internal"
- "github.com/luci/luci-go/server/middleware"
"github.com/luci/luci-go/server/proccache"
+ "github.com/luci/luci-go/server/router"
)
// ServiceInfo describes JSON format of /auth/api/v1/server/info response.
@@ -56,22 +55,22 @@ func FetchServiceInfo(c context.Context, serviceURL string) (*ServiceInfo, error
type ServiceInfoCallback func(context.Context) (ServiceInfo, error)
// InstallHandlers installs handler that serves info provided by the callback.
-func InstallHandlers(r *httprouter.Router, base middleware.Base, cb ServiceInfoCallback) {
- handler := func(c context.Context, w http.ResponseWriter, r *http.Request, p httprouter.Params) {
+func InstallHandlers(r *router.Router, handlers []router.Handler, cb ServiceInfoCallback) {
+ handler := func(c *router.Context) {
var response struct {
ServiceInfo
Error string `json:"error,omitempty"`
}
- info, err := cb(c)
- w.Header().Set("Content-Type", "application/json; charset=utf-8")
+ info, err := cb(c.Context)
+ c.Writer.Header().Set("Content-Type", "application/json; charset=utf-8")
if err != nil {
- w.WriteHeader(http.StatusInternalServerError)
+ c.Writer.WriteHeader(http.StatusInternalServerError)
response.Error = err.Error()
} else {
- w.WriteHeader(http.StatusOK)
+ c.Writer.WriteHeader(http.StatusOK)
response.ServiceInfo = info
}
- json.NewEncoder(w).Encode(response)
+ json.NewEncoder(c.Writer).Encode(response)
}
- r.GET("/auth/api/v1/server/info", base(handler))
+ r.GET("/auth/api/v1/server/info", append(handlers, handler)...)
}

Powered by Google App Engine
This is Rietveld 408576698