Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Unified Diff: appengine/cmd/milo/frontend/milo.go

Issue 2043423004: Make HTTP middleware easier to use (Closed) Base URL: https://github.com/luci/luci-go@master
Patch Set: Update tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/cmd/milo/frontend/milo.go
diff --git a/appengine/cmd/milo/frontend/milo.go b/appengine/cmd/milo/frontend/milo.go
index a231cde1107badb6839a2654cd609dfffc484467..0c144dc323294ffdabc571776ced141f77e09c73 100644
--- a/appengine/cmd/milo/frontend/milo.go
+++ b/appengine/cmd/milo/frontend/milo.go
@@ -7,38 +7,34 @@ package frontend
import (
"net/http"
- "github.com/julienschmidt/httprouter"
-
"github.com/luci/luci-go/appengine/cmd/milo/buildbot"
"github.com/luci/luci-go/appengine/cmd/milo/settings"
"github.com/luci/luci-go/appengine/cmd/milo/swarming"
"github.com/luci/luci-go/appengine/gaemiddleware"
+ "github.com/luci/luci-go/server/router"
)
// Where it all begins!!!
func init() {
// Register plain ol' http services.
- r := httprouter.New()
- gaemiddleware.InstallHandlers(r, settings.Base)
- r.GET("/", wrap(frontpage{}))
- r.GET("/swarming/:server/:id/steps/*logname", wrap(swarming.Log{}))
- r.GET("/swarming/:server/:id", wrap(swarming.Build{}))
+ r := router.New()
+ baseHandlers := settings.Base()
+
+ gaemiddleware.InstallHandlers(r, baseHandlers)
+ r.GET("/", append(baseHandlers, settings.Wrap(frontpage{}))...)
+ r.GET("/swarming/:server/:id/steps/*logname", append(baseHandlers, settings.Wrap(swarming.Log{}))...)
+ r.GET("/swarming/:server/:id", append(baseHandlers, settings.Wrap(swarming.Build{}))...)
// Buildbot
- r.GET("/buildbot/:master/:builder/:build", wrap(buildbot.Build{}))
- r.GET("/buildbot/:master/:builder/", wrap(buildbot.Builder{}))
+ r.GET("/buildbot/:master/:builder/:build", append(baseHandlers, settings.Wrap(buildbot.Build{}))...)
+ r.GET("/buildbot/:master/:builder/", append(baseHandlers, settings.Wrap(buildbot.Builder{}))...)
// User settings
- r.GET("/settings", wrap(settings.Settings{}))
- r.POST("/settings", settings.Base(settings.ChangeSettings))
+ r.GET("/settings", append(baseHandlers, settings.Wrap(settings.Settings{}))...)
+ r.POST("/settings", append(baseHandlers, settings.ChangeSettings)...)
// PubSub subscription endpoints.
- r.POST("/pubsub/buildbot", settings.Base(buildbot.PubSubHandler))
+ r.POST("/pubsub/buildbot", append(baseHandlers, buildbot.PubSubHandler)...)
http.Handle("/", r)
}
-
-// Do all the middleware initilization and theme handling.
-func wrap(h settings.ThemedHandler) httprouter.Handle {
- return settings.Wrap(h)
-}

Powered by Google App Engine
This is Rietveld 408576698