Make HTTP middleware easier to use

appengine/tsmon/handler.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package tsmon
 
 import (
         "net/http"
 
-        "github.com/julienschmidt/httprouter"
         "golang.org/x/net/context"
 
         "github.com/luci/gae/service/datastore"
         "github.com/luci/gae/service/info"
         "github.com/luci/luci-go/common/clock"
         "github.com/luci/luci-go/common/logging"
         "github.com/luci/luci-go/common/parallel"
         "github.com/luci/luci-go/common/tsmon"
-        "github.com/luci/luci-go/server/middleware"
+        "github.com/luci/luci-go/server/router"
 )
 
 // InstallHandlers installs HTTP handlers for tsmon routes.
-func InstallHandlers(r *httprouter.Router, base middleware.Base) {
-        r.GET("/internal/cron/ts_mon/housekeeping", base(housekeepingHandler))
+func InstallHandlers(r *router.Router, base router.MiddlewareChain) {
+        r.GET("/internal/cron/ts_mon/housekeeping", base, housekeepingHandler)
 }
 
 // housekeepingHandler is an HTTP handler that should be run every minute by
 // cron on App Engine.  It assigns task numbers to datastore entries, and runs
 // any global metric callbacks.
-func housekeepingHandler(c context.Context, rw http.ResponseWriter, r *http.Request, p httprouter.Params) {
-        if !info.Get(c).IsDevAppServer() && r.Header.Get("X-Appengine-Cron") != "true" {
-                rw.WriteHeader(http.StatusForbidden)
-                http.Error(rw, "request not made from cron", http.StatusForbidden)
+func housekeepingHandler(c *router.Context) {
+        if !info.Get(c.Context).IsDevAppServer() && c.Request.Header.Get("X-Appengine-Cron") != "true" {
+                c.Writer.WriteHeader(http.StatusForbidden)
+                http.Error(c.Writer, "request not made from cron", http.StatusForbidden)
                 return
         }
 
-        if err := assignTaskNumbers(c); err != nil {
-                rw.WriteHeader(http.StatusInternalServerError)
+        if err := assignTaskNumbers(c.Context); err != nil {
+                c.Writer.WriteHeader(http.StatusInternalServerError)
         }
 
-        tsmon.GetState(c).RunGlobalCallbacks(c)
+        tsmon.GetState(c.Context).RunGlobalCallbacks(c.Context)
 }
 
 // assignTaskNumbers does some housekeeping on the datastore entries for App
 // Engine instances - assigning unique task numbers to those without ones set,
 // and expiring old entities.
 func assignTaskNumbers(c context.Context) error {
         c = info.Get(c).MustNamespace(instanceNamespace)
         ds := datastore.Get(c)
 
         logger := logging.Get(c)
@@ skipping 52 matching lines @@
                 for {
                         n := next
                         next++
                         _, has := used[n]
                         if !has {
                                 return n
                         }
                 }
         }
 }