blimp/engine/testing/Dockerfile - Issue 2043403004: Create a Dockerfile.base and ensure it is included in build tarballs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/engine/testing/Dockerfile

Issue 2043403004: Create a Dockerfile.base and ensure it is included in build tarballs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pull in new apt-get and move testing Dockerfile as suggested. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Testing dockerfile stub	1 # Testing dockerfile stub
Sriram 2016/06/16 18:04:08 Nit: Why is testing under engine instead of blimp/ Nit: Why is testing under engine instead of blimp/testing/Dockerfile? Jess 2016/06/16 18:18:11 I thought at little about that option when Nick su Show quoted text On 2016/06/16 18:04:08, Sriram wrote: > Nit: Why is testing under engine instead of blimp/testing/Dockerfile? I thought at little about that option when Nick suggested moving this file. The environmental testing only makes sense in the context of the engine so I went with the more specific location to start. If you'd like me to drop it down a level, I'd prefer reusing blimp/test instead of having both it and blimp/testing, unless there is some Chrome convention around those directories. Sriram 2016/06/16 18:53:26 That logic does make sense and then it would make Show quoted text On 2016/06/16 18:18:11, Jess wrote: > On 2016/06/16 18:04:08, Sriram wrote: > > Nit: Why is testing under engine instead of blimp/testing/Dockerfile? > > I thought at little about that option when Nick suggested moving this file. The > environmental testing only makes sense in the context of the engine so I went > with the more specific location to start. > > If you'd like me to drop it down a level, I'd prefer reusing blimp/test instead > of having both it and blimp/testing, unless there is some Chrome convention > around those directories. That logic does make sense and then it would make sense to move the test bundle target to also be under engine instead of blimp (the current locaiton). Something to move in follow-up CL?
2 # TODO(jessicag): Fill in (crbug.com/616945).	2 # TODO(jessicag): Fill in (crbug.com/616945).

OLD	NEW

« blimp/engine/BUILD.gn ('K') | « blimp/engine/BUILD.gn ('k') | blimp/tools/Dockerfile.base » ('j') | blimp/tools/Dockerfile.base » ('J')