include/core/SkFlattenable.h - Issue 2043393002: Refactoring of GPU NormalMap handling out into its own class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkFlattenable.h

Issue 2043393002: Refactoring of GPU NormalMap handling out into its own class (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Rebased, unified headers, NormalSource is now serialized, addressed patch 1 comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkFlattenable.h

diff --git a/include/core/SkFlattenable.h b/include/core/SkFlattenable.h

index 260ea33dab481d78d4bc59185054522e47776319..74976793d864a5f913d1e7ee2f5b2768b656ed53 100644

--- a/include/core/SkFlattenable.h

+++ b/include/core/SkFlattenable.h

@@ -81,6 +81,7 @@ public:

kSkShader_Type,

kSkUnused_Type, // used to be SkUnitMapper

kSkXfermode_Type,

+ kNormalSource_Type, // TODO: why is this even necessary?

};

typedef sk_sp<SkFlattenable> (*Factory)(SkReadBuffer&);