Make fake audio file playback loop by default.

Make fake audio file playback loop by default.

Some do long-running tests with --use-file-for-fake-audio-capture, and
since the flag doesn't loop the audio file by default, you'd need a
huge file to play audio during a long-running test.

Instead of specifying <path> you can now specify <path>%noloop for the
flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav%noloop
to get the old behavior. To get the new behavior, just pass a wav file
path to the flag.

The current WebRTC audio quality tests currently need the file to stop
after the first playout. Another option could be to pad the audio file
with lots of silence at the end.

BUG=618215
Committed: https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af
Cr-Commit-Position: refs/heads/master@{#399458}

[phoglund_chromium, 2016-06-08 13:46:03]

Description was changed from

==========
Add the option to loop fake audio file playback.

Some do long-running tests with --use-file-for-fake-audio-capture, and
since the flag doesn't loop the audio file by default, you'd need a
huge file to play audio during a long-running test.

Instead of specifying <path> you can now specify <path>!loop for the
flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav!loop.
This is to preserve backwards compatibility with existing users that
expect the file to only play once.

BUG=618215
==========

to

==========
Make fake audio file playback loop by default.

Some do long-running tests with --use-file-for-fake-audio-capture, and
since the flag doesn't loop the audio file by default, you'd need a
huge file to play audio during a long-running test.

Instead of specifying <path> you can now specify <path>!noloop for the
flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav!noloop
to get the old behavior. To get the new behavior, just pass a wav file
path to the flag.

BUG=618215
==========

[phoglund_chromium, 2016-06-08 13:46:04]

phoglund@chromium.org changed reviewers:
+ tommi@chromium.org

[tommi (sloooow) - chröme, 2016-06-08 14:47:33]

lgtm % nits

https://codereview.chromium.org/2043353002/diff/20001/media/audio/simple_sour...
File media/audio/simple_sources_unittest.cc (right):

https://codereview.chromium.org/2043353002/diff/20001/media/audio/simple_sour...
media/audio/simple_sources_unittest.cc:82: // Convert the test data
(little-endian) into floats and compare.
can you update the comment to explain the value that's assigned to
kFirstSampleIndex?

https://codereview.chromium.org/2043353002/diff/20001/media/audio/simple_sour...
media/audio/simple_sources_unittest.cc:124: bool looping = false;
nit: should this variable/param name be 'loop' rather than 'looping'?  "looping"
to me suggests a current state and not whether we're switching a feature on or
off.

[phoglund_chromium, 2016-06-09 12:08:31]

https://codereview.chromium.org/2043353002/diff/20001/media/audio/simple_sour...
File media/audio/simple_sources_unittest.cc (right):

https://codereview.chromium.org/2043353002/diff/20001/media/audio/simple_sour...
media/audio/simple_sources_unittest.cc:82: // Convert the test data
(little-endian) into floats and compare.
On 2016/06/08 14:47:33, tommi-chrömium wrote:
> can you update the comment to explain the value that's assigned to
> kFirstSampleIndex?

Done.

https://codereview.chromium.org/2043353002/diff/20001/media/audio/simple_sour...
media/audio/simple_sources_unittest.cc:124: bool looping = false;
On 2016/06/08 14:47:33, tommi-chrömium wrote:
> nit: should this variable/param name be 'loop' rather than 'looping'? 
"looping"
> to me suggests a current state and not whether we're switching a feature on or
> off.

Done.

[phoglund_chromium, 2016-06-09 12:13:12]

The CQ bit was checked by phoglund@chromium.org

[phoglund_chromium, 2016-06-09 12:13:13]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2043353002/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-06-09 12:13:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043353002/40001

[commit-bot: I haz the power, 2016-06-09 12:19:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 12:19:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[phoglund_chromium, 2016-06-10 09:55:18]

Description was changed from

==========
Make fake audio file playback loop by default.

Some do long-running tests with --use-file-for-fake-audio-capture, and
since the flag doesn't loop the audio file by default, you'd need a
huge file to play audio during a long-running test.

Instead of specifying <path> you can now specify <path>!noloop for the
flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav!noloop
to get the old behavior. To get the new behavior, just pass a wav file
path to the flag.

BUG=618215
==========

to

==========
Make fake audio file playback loop by default.

Some do long-running tests with --use-file-for-fake-audio-capture, and
since the flag doesn't loop the audio file by default, you'd need a
huge file to play audio during a long-running test.

Instead of specifying <path> you can now specify <path>%noloop for the
flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav!noloop
to get the old behavior. To get the new behavior, just pass a wav file
path to the flag.

BUG=618215
==========

[phoglund_chromium, 2016-06-10 14:19:38]

phoglund@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[phoglund_chromium, 2016-06-10 14:19:39]

+dalecurtis for media_switches.

[phoglund_chromium, 2016-06-10 14:21:29]

Description was changed from

==========
Make fake audio file playback loop by default.

Some do long-running tests with --use-file-for-fake-audio-capture, and
since the flag doesn't loop the audio file by default, you'd need a
huge file to play audio during a long-running test.

Instead of specifying <path> you can now specify <path>%noloop for the
flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav!noloop
to get the old behavior. To get the new behavior, just pass a wav file
path to the flag.

BUG=618215
==========

to

==========
Make fake audio file playback loop by default.

Some do long-running tests with --use-file-for-fake-audio-capture, and
since the flag doesn't loop the audio file by default, you'd need a
huge file to play audio during a long-running test.

Instead of specifying <path> you can now specify <path>%noloop for the
flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav%noloop
to get the old behavior. To get the new behavior, just pass a wav file
path to the flag.

The current WebRTC audio quality tests currently need the file to stop
after the first playout. Another option could be to pad the audio file
with lots of silence at the end.

BUG=618215
==========

[DaleCurtis, 2016-06-10 18:25:03]

lgtm

[phoglund_chromium, 2016-06-13 06:52:04]

The CQ bit was checked by phoglund@chromium.org

[phoglund_chromium, 2016-06-13 06:52:05]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2043353002/#ps70001
(title: "Update browser test")

[commit-bot: I haz the power, 2016-06-13 06:52:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043353002/70001

[commit-bot: I haz the power, 2016-06-13 07:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 07:15:51]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[phoglund_chromium, 2016-06-13 07:29:23]

The CQ bit was checked by phoglund@chromium.org

[phoglund_chromium, 2016-06-13 07:29:24]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org,
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2043353002/#ps90001
(title: "Fix literal")

[commit-bot: I haz the power, 2016-06-13 07:29:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043353002/90001

[commit-bot: I haz the power, 2016-06-13 08:00:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 08:00:04]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[phoglund_chromium, 2016-06-13 10:50:02]

The CQ bit was checked by phoglund@chromium.org

[phoglund_chromium, 2016-06-13 10:50:02]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org,
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2043353002/#ps110001
(title: "String handling is hard")

[commit-bot: I haz the power, 2016-06-13 10:50:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043353002/110001

[commit-bot: I haz the power, 2016-06-13 15:47:19]

Description was changed from

==========
Make fake audio file playback loop by default.

Some do long-running tests with --use-file-for-fake-audio-capture, and
since the flag doesn't loop the audio file by default, you'd need a
huge file to play audio during a long-running test.

Instead of specifying <path> you can now specify <path>%noloop for the
flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav%noloop
to get the old behavior. To get the new behavior, just pass a wav file
path to the flag.

The current WebRTC audio quality tests currently need the file to stop
after the first playout. Another option could be to pad the audio file
with lots of silence at the end.

BUG=618215
==========

to

==========
Make fake audio file playback loop by default.

Some do long-running tests with --use-file-for-fake-audio-capture, and
since the flag doesn't loop the audio file by default, you'd need a
huge file to play audio during a long-running test.

Instead of specifying <path> you can now specify <path>%noloop for the
flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav%noloop
to get the old behavior. To get the new behavior, just pass a wav file
path to the flag.

The current WebRTC audio quality tests currently need the file to stop
after the first playout. Another option could be to pad the audio file
with lots of silence at the end.

BUG=618215
==========

[commit-bot: I haz the power, 2016-06-13 15:47:29]

Committed patchset #7 (id:110001)

[commit-bot: I haz the power, 2016-06-13 15:47:32]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 15:49:34]

Description was changed from

==========
Make fake audio file playback loop by default.

Some do long-running tests with --use-file-for-fake-audio-capture, and
since the flag doesn't loop the audio file by default, you'd need a
huge file to play audio during a long-running test.

Instead of specifying <path> you can now specify <path>%noloop for the
flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav%noloop
to get the old behavior. To get the new behavior, just pass a wav file
path to the flag.

The current WebRTC audio quality tests currently need the file to stop
after the first playout. Another option could be to pad the audio file
with lots of silence at the end.

BUG=618215
==========

to

==========
Make fake audio file playback loop by default.

Some do long-running tests with --use-file-for-fake-audio-capture, and
since the flag doesn't loop the audio file by default, you'd need a
huge file to play audio during a long-running test.

Instead of specifying <path> you can now specify <path>%noloop for the
flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav%noloop
to get the old behavior. To get the new behavior, just pass a wav file
path to the flag.

The current WebRTC audio quality tests currently need the file to stop
after the first playout. Another option could be to pad the audio file
with lots of silence at the end.

BUG=618215

Committed: https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af
Cr-Commit-Position: refs/heads/master@{#399458}
==========

[commit-bot: I haz the power, 2016-06-13 15:49:35]

Patchset 7 (id:??) landed as
https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af
Cr-Commit-Position: refs/heads/master@{#399458}