Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 204333005: Fix an MQ parsing related crash (Closed)

Created:
6 years, 9 months ago by Yoav Weiss
Modified:
6 years, 9 months ago
Reviewers:
dglazkov, eseidel
CC:
blink-reviews, kenneth.christiansen, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, kareng
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix an MQ parsing related crash When MediaQueryParser used valuesList.clear(), clear() cleared the list's values, but not the offset of the current read value. This fixes that. BUG=353988 Possibly related to BUG=353982 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169630

Patch Set 1 #

Patch Set 2 : Added a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M Source/core/css/CSSParserValues.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSParserValuesTest.cpp View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/css/MediaQueryExp.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Yoav Weiss
This fixes https://code.google.com/p/chromium/issues/detail?id=353982
6 years, 9 months ago (2014-03-19 17:30:18 UTC) #1
eseidel
You didn't change CSSParserValues when you made your original change, why is this part needed? ...
6 years, 9 months ago (2014-03-19 17:45:12 UTC) #2
Yoav Weiss
On 2014/03/19 17:45:12, eseidel wrote: > You didn't change CSSParserValues when you made your original ...
6 years, 9 months ago (2014-03-19 17:51:04 UTC) #3
eseidel
lgtm A test would still be good.
6 years, 9 months ago (2014-03-19 18:32:55 UTC) #4
Yoav Weiss
On 2014/03/19 18:32:55, eseidel wrote: > lgtm > > A test would still be good. ...
6 years, 9 months ago (2014-03-19 19:17:12 UTC) #5
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 9 months ago (2014-03-19 19:19:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/204333005/10001
6 years, 9 months ago (2014-03-19 19:19:11 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 20:27:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-19 20:27:13 UTC) #9
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 9 months ago (2014-03-19 21:28:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/204333005/10001
6 years, 9 months ago (2014-03-19 21:28:10 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 21:46:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-19 21:46:10 UTC) #13
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 9 months ago (2014-03-19 21:50:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/204333005/10001
6 years, 9 months ago (2014-03-19 21:50:18 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 23:04:52 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-19 23:04:52 UTC) #17
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 9 months ago (2014-03-20 06:00:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/204333005/10001
6 years, 9 months ago (2014-03-20 06:00:32 UTC) #19
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 07:00:36 UTC) #20
Message was sent while issue was closed.
Change committed as 169630

Powered by Google App Engine
This is Rietveld 408576698