Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 204333004: DevTools: Speculatively patch DevTools to make CodeSchool extension work. (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 8 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Speculatively patch DevTools to make CodeSchool extension work. R=pfeldman@chromium.org, pfeldman NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170155

Patch Set 1 #

Patch Set 2 : Fixed pause settings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
M Source/devtools/front_end/HeapSnapshotView.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/devtools/front_end/Main.js View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Source/devtools/front_end/Settings.js View 1 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
vsevik
PTAL
6 years, 9 months ago (2014-03-19 13:25:44 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-19 16:54:27 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 8 months ago (2014-03-27 08:04:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/204333004/20001
6 years, 8 months ago (2014-03-27 08:04:14 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 09:12:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-03-27 09:12:19 UTC) #6
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 8 months ago (2014-03-27 09:47:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/204333004/20001
6 years, 8 months ago (2014-03-27 09:47:55 UTC) #8
vsevik
The CQ bit was unchecked by vsevik@chromium.org
6 years, 8 months ago (2014-03-27 09:48:47 UTC) #9
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 8 months ago (2014-03-27 09:48:51 UTC) #10
vsevik
The CQ bit was unchecked by vsevik@chromium.org
6 years, 8 months ago (2014-03-27 09:50:49 UTC) #11
vsevik
6 years, 8 months ago (2014-03-27 09:51:04 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 manually as r170155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698