Issue 204333002: Minor Refactor in RenderListBox

Issue 204333002: Minor Refactor in RenderListBox (Closed)

Created:
6 years, 9 months ago by spartha

Modified:
6 years, 9 months ago

Reviewers:
tkent, esprehn, eseidel

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Minor Refactor in RenderListBox This is a minor refactor, that removes an unused private member function valueChanged. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169543

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	Source/core/rendering/RenderListBox.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/core/rendering/RenderListBox.cpp	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 12 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/204333002/1

6 years, 9 months ago (2014-03-19 10:55:38 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-19 10:58:00 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.blink on win_blink_rel

6 years, 9 months ago (2014-03-19 10:58:01 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/204333002/1

6 years, 9 months ago (2014-03-19 11:02:11 UTC) #10

spartha

6 years, 9 months ago (2014-03-19 17:33:37 UTC) #12

Message was sent while issue was closed.

On 2014/03/19 10:55:28, esprehn wrote:
> You don't need the empty BUG= lines. I removed it.
> 
> lgtm

ok ... Thanks!