Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2043313003: Add more pdf codec fuzzers. (Closed)

Created:
4 years, 6 months ago by Oliver Chang
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more pdf codec fuzzers. R=thestig@chromium.org,dsinclair@chromium.org BUG=617659, 616842, 616841, 616839 Committed: https://crrev.com/7751e5d2a12f07c7538230b6654b1339b7ee2742 Cr-Commit-Position: refs/heads/master@{#398811}

Patch Set 1 #

Patch Set 2 : missed one #

Patch Set 3 : alpha order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M pdf/pdfium/fuzzers/BUILD.gn View 1 2 2 chunks +34 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Oliver Chang
ptal. this adds the rest of the fuzzers that Dan implemented.
4 years, 6 months ago (2016-06-09 03:57:39 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-09 05:20:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043313003/40001
4 years, 6 months ago (2016-06-09 07:07:42 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 07:49:51 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/7751e5d2a12f07c7538230b6654b1339b7ee2742 Cr-Commit-Position: refs/heads/master@{#398811}
4 years, 6 months ago (2016-06-09 07:51:39 UTC) #9
dsinclair
On 2016/06/09 03:57:39, Oliver Chang wrote: > ptal. this adds the rest of the fuzzers ...
4 years, 6 months ago (2016-06-09 12:59:12 UTC) #10
Oliver Chang
On 2016/06/09 12:59:12, dsinclair wrote: > On 2016/06/09 03:57:39, Oliver Chang wrote: > > ptal. ...
4 years, 6 months ago (2016-06-09 15:21:32 UTC) #11
Oliver Chang
4 years, 6 months ago (2016-06-09 15:21:35 UTC) #12
Message was sent while issue was closed.
On 2016/06/09 12:59:12, dsinclair wrote:
> On 2016/06/09 03:57:39, Oliver Chang wrote:
> > ptal. this adds the rest of the fuzzers that Dan implemented.
> 
> 
> I was originally holding off landing this change until I could see the results
> from the png fuzzer. Looking at what has been found, I'm not sure if it's
doing
> what we want it to do. It appears the PNG fuzzer is finding issues in the GIF
> code, so I'm thinking XFA is ignoring the provided image type flag in some
cases
> and doing what it wants.
> 
> I have a feeling, these are all going to end up testing the same code paths
> since they all start with the same test corpii.

Ah, I haven't looked at the png one too closely yet, and we can always revert.

Either way, we'll want to have different instances running with different
corpora, which I'll upload today. I'll also give you access to PDF security bugs
on CF.

Powered by Google App Engine
This is Rietveld 408576698