Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 2043293002: arc: Clear the ARC task list when ARC get disabled. (Closed)

Created:
4 years, 6 months ago by Shuhei Takahashi
Modified:
4 years, 6 months ago
Reviewers:
afakhry, cylee1, cylee
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Clear the ARC task list when ARC get disabled. BUG=b:29154797 TEST=trybots TEST=Manually tested Committed: https://crrev.com/cc39f41cd320bf1ce4f1eec30d278b44afc01847 Cr-Commit-Position: refs/heads/master@{#398780}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/browser/task_management/providers/arc/arc_process_task_provider.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Shuhei Takahashi
afakhry, cylee: PTAL
4 years, 6 months ago (2016-06-08 09:03:42 UTC) #2
cylee
lgtm https://codereview.chromium.org/2043293002/diff/1/chrome/browser/task_management/providers/arc/arc_process_task_provider.cc File chrome/browser/task_management/providers/arc/arc_process_task_provider.cc (right): https://codereview.chromium.org/2043293002/diff/1/chrome/browser/task_management/providers/arc/arc_process_task_provider.cc#newcode101 chrome/browser/task_management/providers/arc/arc_process_task_provider.cc:101: callback.Run(std::vector<ArcProcess>()); Could you add a comment to make ...
4 years, 6 months ago (2016-06-08 09:58:01 UTC) #4
Shuhei Takahashi
https://codereview.chromium.org/2043293002/diff/1/chrome/browser/task_management/providers/arc/arc_process_task_provider.cc File chrome/browser/task_management/providers/arc/arc_process_task_provider.cc (right): https://codereview.chromium.org/2043293002/diff/1/chrome/browser/task_management/providers/arc/arc_process_task_provider.cc#newcode101 chrome/browser/task_management/providers/arc/arc_process_task_provider.cc:101: callback.Run(std::vector<ArcProcess>()); On 2016/06/08 09:58:01, cylee wrote: > Could you ...
4 years, 6 months ago (2016-06-08 10:50:21 UTC) #5
afakhry
lgtm
4 years, 6 months ago (2016-06-08 13:15:53 UTC) #6
Shuhei Takahashi
Thanks for reviews! Please allow me to submit this change a bit later (1-2 days) ...
4 years, 6 months ago (2016-06-08 13:19:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043293002/20001
4 years, 6 months ago (2016-06-09 03:44:32 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 04:18:34 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 04:20:10 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cc39f41cd320bf1ce4f1eec30d278b44afc01847
Cr-Commit-Position: refs/heads/master@{#398780}

Powered by Google App Engine
This is Rietveld 408576698