third_party/WebKit/Source/core/animation/StringKeyframe.h - Issue 2043273002: Defer compositor keyframe snapshots until the next style resolve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/StringKeyframe.h

Issue 2043273002: Defer compositor keyframe snapshots until the next style resolve (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp ('k') | third_party/WebKit/Source/core/animation/StringKeyframe.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/StringKeyframe.h

diff --git a/third_party/WebKit/Source/core/animation/StringKeyframe.h b/third_party/WebKit/Source/core/animation/StringKeyframe.h

index 411aedf6945b2e58c8429f34543756b73f37f5ee..fa161e69f6f8517d7733b0ea7bbb071ac70744fc 100644

--- a/third_party/WebKit/Source/core/animation/StringKeyframe.h

+++ b/third_party/WebKit/Source/core/animation/StringKeyframe.h

@@ -57,7 +57,7 @@ public:

CSSValue* value() const { return m_value.get(); }

- virtual bool populateAnimatableValue(CSSPropertyID, Element&, const ComputedStyle* baseStyle, bool force) const;

+ bool populateAnimatableValue(CSSPropertyID, Element&, const ComputedStyle& baseStyle, const ComputedStyle* parentStyle) const final;

const PassRefPtr<AnimatableValue> getAnimatableValue() const final { return m_animatableValueCache.get(); }

void setAnimatableValue(PassRefPtr<AnimatableValue> value) { m_animatableValueCache = value; }