third_party/WebKit/Source/core/animation/Keyframe.h - Issue 2043273002: Defer compositor keyframe snapshots until the next style resolve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/Keyframe.h

Issue 2043273002: Defer compositor keyframe snapshots until the next style resolve (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/InterpolableValue.h ('k') | third_party/WebKit/Source/core/animation/KeyframeEffectModel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/Keyframe.h

diff --git a/third_party/WebKit/Source/core/animation/Keyframe.h b/third_party/WebKit/Source/core/animation/Keyframe.h

index 4301cd4bcdb57afdeb2650f9aa50728fabbb0e75..5a32af1452d92051c48f2bbaed8c032f47ac60d4 100644

--- a/third_party/WebKit/Source/core/animation/Keyframe.h

+++ b/third_party/WebKit/Source/core/animation/Keyframe.h

@@ -72,7 +72,7 @@ public:

virtual PassRefPtr<PropertySpecificKeyframe> cloneWithOffset(double offset) const = 0;

// FIXME: Remove this once CompositorAnimations no longer depends on AnimatableValues

- virtual bool populateAnimatableValue(CSSPropertyID, Element&, const ComputedStyle* baseStyle, bool force) const { return false; }

+ virtual bool populateAnimatableValue(CSSPropertyID, Element&, const ComputedStyle& baseStyle, const ComputedStyle* parentStyle) const { return false; }

virtual const PassRefPtr<AnimatableValue> getAnimatableValue() const = 0;

virtual bool isAnimatableValuePropertySpecificKeyframe() const { return false; }