Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2043263002: Revert of [heap] Uncommit unused large object page memory. (Closed)

Created:
4 years, 6 months ago by Hannes Payer (out of office)
Modified:
4 years, 6 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Uncommit unused large object page memory. (patchset #13 id:230001 of https://codereview.chromium.org/2032393002/ ) Reason for revert: Needs fixing of slot set. Original issue's description: > [heap] Uncommit unused large object page memory. > > As a first step I uncommit the memory on the main thread. Also to measure impact and stability of that optimization. In a follow-up CL, the uncommitting should be moved on the concurrent thread. > > BUG= > > Committed: https://crrev.com/d61a5c376ba51145dc4684e39d5d3a9ce75bcfa6 > Cr-Commit-Position: refs/heads/master@{#36763} TBR=ulan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/1e3a38d9624b8f9e4a8a4e084848e933f55ff647 Cr-Commit-Position: refs/heads/master@{#36807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -112 lines) Patch
M src/base/platform/platform.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/base/platform/platform-linux.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/base/platform/platform-macos.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/base/platform/platform-win32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/spaces.h View 4 chunks +1 line, -7 lines 0 comments Download
M src/heap/spaces.cc View 5 chunks +1 line, -43 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Hannes Payer (out of office)
Created Revert of [heap] Uncommit unused large object page memory.
4 years, 6 months ago (2016-06-08 06:12:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043263002/1
4 years, 6 months ago (2016-06-08 06:12:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 06:52:28 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 06:53:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e3a38d9624b8f9e4a8a4e084848e933f55ff647
Cr-Commit-Position: refs/heads/master@{#36807}

Powered by Google App Engine
This is Rietveld 408576698