third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp - Issue 2043233003: Prevent sign extension for pointer trace values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

Issue 2043233003: Prevent sign extension for pointer trace values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp b/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

index 49277e106cc8f957af314c36a63fa640e22b54d2..bde0fe4cbe6d96cf15d4164230a87727b38c7cdf 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

@@ -41,7 +41,7 @@ namespace blink {

String toHexString(const void* p)

{

- return String::format("0x%" PRIx64, static_cast<uint64_t>(reinterpret_cast<intptr_t>(p)));

+ return String::format("0x%" PRIx64, static_cast<uint64_t>(reinterpret_cast<uintptr_t>(p)));

}

void setCallStack(TracedValue* value)