Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Side by Side Diff: Source/devtools/front_end/SourcesPanel.js

Issue 204323003: DevTools: Merge highlightPosition and revealLine methods on SourceFrame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed tests Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/SourceFrame.js ('k') | Source/devtools/front_end/TextEditor.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 698 matching lines...) Expand 10 before | Expand all | Expand 10 after
709 this._clearCurrentExecutionLine(); 709 this._clearCurrentExecutionLine();
710 this._setExecutionLine(uiLocation); 710 this._setExecutionLine(uiLocation);
711 711
712 var uiSourceCode = uiLocation.uiSourceCode; 712 var uiSourceCode = uiLocation.uiSourceCode;
713 var scriptFile = this._currentUISourceCode ? this._currentUISourceCode.s criptFile() : null; 713 var scriptFile = this._currentUISourceCode ? this._currentUISourceCode.s criptFile() : null;
714 if (this._skipExecutionLineRevealing) 714 if (this._skipExecutionLineRevealing)
715 return; 715 return;
716 this._skipExecutionLineRevealing = true; 716 this._skipExecutionLineRevealing = true;
717 717
718 var sourceFrame = this._showFile(uiSourceCode); 718 var sourceFrame = this._showFile(uiSourceCode);
719 sourceFrame.revealLine(uiLocation.lineNumber); 719 sourceFrame.revealPosition(uiLocation.lineNumber);
720 this._historyManager.pushNewState(); 720 this._historyManager.pushNewState();
721 721
722 if (sourceFrame.canEditSource()) 722 if (sourceFrame.canEditSource())
723 sourceFrame.setSelection(WebInspector.TextRange.createFromLocation(u iLocation.lineNumber, 0)); 723 sourceFrame.setSelection(WebInspector.TextRange.createFromLocation(u iLocation.lineNumber, 0));
724 sourceFrame.focus(); 724 sourceFrame.focus();
725 }, 725 },
726 726
727 _callFrameSelected: function(event) 727 _callFrameSelected: function(event)
728 { 728 {
729 var callFrame = event.data; 729 var callFrame = event.data;
(...skipping 992 matching lines...) Expand 10 before | Expand all | Expand 10 after
1722 { 1722 {
1723 } 1723 }
1724 1724
1725 WebInspector.SourcesPanel.EditorAction.prototype = { 1725 WebInspector.SourcesPanel.EditorAction.prototype = {
1726 /** 1726 /**
1727 * @param {!WebInspector.SourcesPanel} panel 1727 * @param {!WebInspector.SourcesPanel} panel
1728 * @return {!Element} 1728 * @return {!Element}
1729 */ 1729 */
1730 button: function(panel) { } 1730 button: function(panel) { }
1731 } 1731 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/SourceFrame.js ('k') | Source/devtools/front_end/TextEditor.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698