src/runtime/runtime-strings.cc - Issue 2043183003: Replace all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-strings.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: simplifying checks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-strings.cc

diff --git a/src/runtime/runtime-strings.cc b/src/runtime/runtime-strings.cc

index 8df345313698e197ae3384456f321c989e096f86..3ffde6573daa940fcabaf806ac7d9821671f36cb 100644

--- a/src/runtime/runtime-strings.cc

+++ b/src/runtime/runtime-strings.cc

@@ -1057,7 +1057,7 @@ MUST_USE_RESULT static Object* ConvertCase(

}

Object* answer = ConvertCaseHelper(isolate, *s, *result, length, mapping);

- if (answer->IsException() || answer->IsString()) return answer;

+ if (answer->IsException(isolate) || answer->IsString()) return answer;

DCHECK(answer->IsSmi());

length = Smi::cast(answer)->value();