src/full-codegen/x64/full-codegen-x64.cc - Issue 2043183003: Replace all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: simplifying checks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index 3cbdaca6fd0585736ca9d869f1551859e7fe6d78..3ff1011b3d9c33af07ade4267bbdec53856c65c6 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -504,11 +504,12 @@ void FullCodeGenerator::TestContext::Plug(Handle<Object> lit) const {

true,

true_label_,

false_label_);

- DCHECK(lit->IsNull() || lit->IsUndefined(isolate()) ||

+ DCHECK(lit->IsNull(isolate()) || lit->IsUndefined(isolate()) ||

!lit->IsUndetectable());

- if (lit->IsUndefined(isolate()) || lit->IsNull() || lit->IsFalse()) {

+ if (lit->IsUndefined(isolate()) || lit->IsNull(isolate()) ||

+ lit->IsFalse(isolate())) {

if (false_label_ != fall_through_) __ jmp(false_label_);

- } else if (lit->IsTrue() || lit->IsJSObject()) {

+ } else if (lit->IsTrue(isolate()) || lit->IsJSObject()) {

if (true_label_ != fall_through_) __ jmp(true_label_);

} else if (lit->IsString()) {

if (String::cast(*lit)->length() == 0) {