src/factory.cc - Issue 2043183003: Replace all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: simplifying checks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 34c2bc5c69cd4a98ad5c3e2c2d189a8e67f92873..a72946749b8502dd31798194e41561418c04c509 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -2012,7 +2012,7 @@ Handle<JSProxy> Factory::NewJSProxy(Handle<JSReceiver> target,

} else {

map = Handle<Map>(isolate()->proxy_map());

}

- DCHECK(map->prototype()->IsNull());

+ DCHECK(map->prototype()->IsNull(isolate()));

Handle<JSProxy> result = New<JSProxy>(map, NEW_SPACE);

result->initialize_properties();

result->set_target(*target);