src/compiler/js-call-reducer.cc - Issue 2043183003: Replace all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-call-reducer.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: simplifying checks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-call-reducer.cc

diff --git a/src/compiler/js-call-reducer.cc b/src/compiler/js-call-reducer.cc

index 0f80d28de8423ecdead40993f0f1485ca7f37b2a..a69d1f231086d57b9763d17379e4e7eaa7f1a8bb 100644

--- a/src/compiler/js-call-reducer.cc

+++ b/src/compiler/js-call-reducer.cc

@@ -269,7 +269,7 @@ Reduction JSCallReducer::ReduceJSCallFunction(Node* node) {

isolate());

CallFunctionParameters const& p = CallFunctionParametersOf(node->op());

ConvertReceiverMode const convert_mode =

- (bound_this->IsNull() || bound_this->IsUndefined(isolate()))

+ (bound_this->IsNull(isolate()) || bound_this->IsUndefined(isolate()))

? ConvertReceiverMode::kNullOrUndefined

: ConvertReceiverMode::kNotNullOrUndefined;

size_t arity = p.arity();