Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: src/code-stubs.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: simplifying checks Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.cc ('k') | src/compiler/access-info.cc » ('j') | src/objects.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.cc
diff --git a/src/code-stubs.cc b/src/code-stubs.cc
index 07cb4f11dd10b6fd9f8749675a7714e16360d9cc..19ba048f33928f58d9a6fc70848786ab125b72b4 100644
--- a/src/code-stubs.cc
+++ b/src/code-stubs.cc
@@ -4547,8 +4547,8 @@ bool ToBooleanICStub::Types::UpdateStatus(Isolate* isolate,
return false;
} else if (object->IsBoolean()) {
Add(BOOLEAN);
- return object->IsTrue();
- } else if (object->IsNull()) {
+ return object->IsTrue(isolate);
+ } else if (object->IsNull(isolate)) {
Add(NULL_TYPE);
return false;
} else if (object->IsSmi()) {
« no previous file with comments | « src/builtins.cc ('k') | src/compiler/access-info.cc » ('j') | src/objects.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698