test/cctest/test-api.h - Issue 2043183003: Replace all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.h

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: keep em coming Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-api.h

diff --git a/test/cctest/test-api.h b/test/cctest/test-api.h

index 1a70c68b92c46d28443f4c7b2d74bf3154b60dc9..f9a335a7f4ccc686b5811a720b258f9b488f0624 100644

--- a/test/cctest/test-api.h

+++ b/test/cctest/test-api.h

@@ -28,7 +28,7 @@ static void CheckReturnValue(const T& t, i::Address callback) {

CHECK(!(*o)->IsTheHole(isolate) && !(*o)->IsUndefined(isolate));

rv.Set(v8::Local<v8::Object>());

CHECK((*o)->IsTheHole(isolate) || (*o)->IsUndefined(isolate));

- CHECK_EQ(is_runtime, (*o)->IsTheHole());

+ CHECK_EQ(is_runtime, (*o)->IsTheHole(isolate));

// If CPU profiler is active check that when API callback is invoked

// VMState is set to EXTERNAL.

if (isolate->is_profiling()) {

« no previous file with comments | « test/cctest/heap/test-heap.cc ('k') | test/cctest/test-dictionary.cc » ('j') | no next file with comments »