src/global-handles.cc - Issue 2043183003: Replace all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/global-handles.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: keep em coming Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/global-handles.cc

diff --git a/src/global-handles.cc b/src/global-handles.cc

index f1790b62497166c17103134b401f0352993c40c8..dffa2371136bf57eb05838dfcbb7c82622b6e1df 100644

--- a/src/global-handles.cc

+++ b/src/global-handles.cc

@@ -891,7 +891,7 @@ void ObjectGroupsTracer::PrintConstructor(JSObject* js_object) {

if (name->length() == 0) name = constructor->shared()->inferred_name();

PrintF("%s", name->ToCString().get());

- } else if (maybe_constructor->IsNull()) {

+ } else if (maybe_constructor->IsNull(isolate_)) {

if (js_object->IsOddball()) {

PrintF("<oddball>");

} else {

« no previous file with comments | « src/futex-emulation.cc ('k') | src/ic/handler-compiler.cc » ('j') | no next file with comments »