Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: src/messages.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: simplifying checks Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/lookup.cc ('k') | src/objects.h » ('j') | src/objects.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/messages.h" 5 #include "src/messages.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/execution.h" 8 #include "src/execution.h"
9 #include "src/isolate-inl.h" 9 #include "src/isolate-inl.h"
10 #include "src/keys.h" 10 #include "src/keys.h"
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 if (accessors->IsAccessorPair()) { 244 if (accessors->IsAccessorPair()) {
245 Handle<AccessorPair> pair = Handle<AccessorPair>::cast(accessors); 245 Handle<AccessorPair> pair = Handle<AccessorPair>::cast(accessors);
246 return pair->getter() == *fun || pair->setter() == *fun; 246 return pair->getter() == *fun || pair->setter() == *fun;
247 } 247 }
248 } 248 }
249 return false; 249 return false;
250 } 250 }
251 251
252 252
253 Handle<Object> CallSite::GetMethodName() { 253 Handle<Object> CallSite::GetMethodName() {
254 if (!IsJavaScript() || receiver_->IsNull() || 254 if (!IsJavaScript() || receiver_->IsNull(isolate_) ||
255 receiver_->IsUndefined(isolate_)) { 255 receiver_->IsUndefined(isolate_)) {
256 return isolate_->factory()->null_value(); 256 return isolate_->factory()->null_value();
257 } 257 }
258 Handle<JSReceiver> receiver = 258 Handle<JSReceiver> receiver =
259 Object::ToObject(isolate_, receiver_).ToHandleChecked(); 259 Object::ToObject(isolate_, receiver_).ToHandleChecked();
260 if (!receiver->IsJSObject()) { 260 if (!receiver->IsJSObject()) {
261 return isolate_->factory()->null_value(); 261 return isolate_->factory()->null_value();
262 } 262 }
263 263
264 Handle<JSObject> obj = Handle<JSObject>::cast(receiver); 264 Handle<JSObject> obj = Handle<JSObject>::cast(receiver);
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 bool CallSite::IsNative() { 337 bool CallSite::IsNative() {
338 if (!IsJavaScript()) return false; 338 if (!IsJavaScript()) return false;
339 Handle<Object> script(fun_->shared()->script(), isolate_); 339 Handle<Object> script(fun_->shared()->script(), isolate_);
340 return script->IsScript() && 340 return script->IsScript() &&
341 Handle<Script>::cast(script)->type() == Script::TYPE_NATIVE; 341 Handle<Script>::cast(script)->type() == Script::TYPE_NATIVE;
342 } 342 }
343 343
344 344
345 bool CallSite::IsToplevel() { 345 bool CallSite::IsToplevel() {
346 if (IsWasm()) return false; 346 if (IsWasm()) return false;
347 return receiver_->IsJSGlobalProxy() || receiver_->IsNull() || 347 return receiver_->IsJSGlobalProxy() || receiver_->IsNull(isolate_) ||
348 receiver_->IsUndefined(isolate_); 348 receiver_->IsUndefined(isolate_);
349 } 349 }
350 350
351 351
352 bool CallSite::IsEval() { 352 bool CallSite::IsEval() {
353 if (!IsJavaScript()) return false; 353 if (!IsJavaScript()) return false;
354 Handle<Object> script(fun_->shared()->script(), isolate_); 354 Handle<Object> script(fun_->shared()->script(), isolate_);
355 return script->IsScript() && 355 return script->IsScript() &&
356 Handle<Script>::cast(script)->compilation_type() == 356 Handle<Script>::cast(script)->compilation_type() ==
357 Script::COMPILATION_TYPE_EVAL; 357 Script::COMPILATION_TYPE_EVAL;
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 builder.AppendCharacter(*c); 444 builder.AppendCharacter(*c);
445 } 445 }
446 } 446 }
447 447
448 return builder.Finish(); 448 return builder.Finish();
449 } 449 }
450 450
451 451
452 } // namespace internal 452 } // namespace internal
453 } // namespace v8 453 } // namespace v8
OLDNEW
« no previous file with comments | « src/lookup.cc ('k') | src/objects.h » ('j') | src/objects.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698