Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: src/factory.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: simplifying checks Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/factory.h" 5 #include "src/factory.h"
6 6
7 #include "src/allocation-site-scopes.h" 7 #include "src/allocation-site-scopes.h"
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/conversions.h" 10 #include "src/conversions.h"
(...skipping 1994 matching lines...) Expand 10 before | Expand all | Expand 10 after
2005 Handle<Map> map; 2005 Handle<Map> map;
2006 if (target->IsCallable()) { 2006 if (target->IsCallable()) {
2007 if (target->IsConstructor()) { 2007 if (target->IsConstructor()) {
2008 map = Handle<Map>(isolate()->proxy_constructor_map()); 2008 map = Handle<Map>(isolate()->proxy_constructor_map());
2009 } else { 2009 } else {
2010 map = Handle<Map>(isolate()->proxy_callable_map()); 2010 map = Handle<Map>(isolate()->proxy_callable_map());
2011 } 2011 }
2012 } else { 2012 } else {
2013 map = Handle<Map>(isolate()->proxy_map()); 2013 map = Handle<Map>(isolate()->proxy_map());
2014 } 2014 }
2015 DCHECK(map->prototype()->IsNull()); 2015 DCHECK(map->prototype()->IsNull(isolate()));
2016 Handle<JSProxy> result = New<JSProxy>(map, NEW_SPACE); 2016 Handle<JSProxy> result = New<JSProxy>(map, NEW_SPACE);
2017 result->initialize_properties(); 2017 result->initialize_properties();
2018 result->set_target(*target); 2018 result->set_target(*target);
2019 result->set_handler(*handler); 2019 result->set_handler(*handler);
2020 result->set_hash(*undefined_value(), SKIP_WRITE_BARRIER); 2020 result->set_hash(*undefined_value(), SKIP_WRITE_BARRIER);
2021 return result; 2021 return result;
2022 } 2022 }
2023 2023
2024 2024
2025 Handle<JSGlobalProxy> Factory::NewUninitializedJSGlobalProxy() { 2025 Handle<JSGlobalProxy> Factory::NewUninitializedJSGlobalProxy() {
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
2394 } 2394 }
2395 2395
2396 2396
2397 Handle<Object> Factory::ToBoolean(bool value) { 2397 Handle<Object> Factory::ToBoolean(bool value) {
2398 return value ? true_value() : false_value(); 2398 return value ? true_value() : false_value();
2399 } 2399 }
2400 2400
2401 2401
2402 } // namespace internal 2402 } // namespace internal
2403 } // namespace v8 2403 } // namespace v8
OLDNEW
« no previous file with comments | « src/execution.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | src/objects.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698