Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: keep em coming Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 __ li(result_register(), Operand(lit)); 524 __ li(result_register(), Operand(lit));
525 codegen()->PushOperand(result_register()); 525 codegen()->PushOperand(result_register());
526 } 526 }
527 527
528 528
529 void FullCodeGenerator::TestContext::Plug(Handle<Object> lit) const { 529 void FullCodeGenerator::TestContext::Plug(Handle<Object> lit) const {
530 codegen()->PrepareForBailoutBeforeSplit(condition(), 530 codegen()->PrepareForBailoutBeforeSplit(condition(),
531 true, 531 true,
532 true_label_, 532 true_label_,
533 false_label_); 533 false_label_);
534 DCHECK(lit->IsNull() || lit->IsUndefined(isolate()) || 534 DCHECK(lit->IsNull(isolate()) || lit->IsUndefined(isolate()) ||
535 !lit->IsUndetectable()); 535 !lit->IsUndetectable());
536 if (lit->IsUndefined(isolate()) || lit->IsNull() || lit->IsFalse()) { 536 if (lit->IsUndefined(isolate()) || lit->IsNull(isolate()) ||
537 lit->IsFalse(isolate())) {
537 if (false_label_ != fall_through_) __ Branch(false_label_); 538 if (false_label_ != fall_through_) __ Branch(false_label_);
538 } else if (lit->IsTrue() || lit->IsJSObject()) { 539 } else if (lit->IsTrue(isolate()) || lit->IsJSObject()) {
539 if (true_label_ != fall_through_) __ Branch(true_label_); 540 if (true_label_ != fall_through_) __ Branch(true_label_);
540 } else if (lit->IsString()) { 541 } else if (lit->IsString()) {
541 if (String::cast(*lit)->length() == 0) { 542 if (String::cast(*lit)->length() == 0) {
542 if (false_label_ != fall_through_) __ Branch(false_label_); 543 if (false_label_ != fall_through_) __ Branch(false_label_);
543 } else { 544 } else {
544 if (true_label_ != fall_through_) __ Branch(true_label_); 545 if (true_label_ != fall_through_) __ Branch(true_label_);
545 } 546 }
546 } else if (lit->IsSmi()) { 547 } else if (lit->IsSmi()) {
547 if (Smi::cast(*lit)->value() == 0) { 548 if (Smi::cast(*lit)->value() == 0) {
548 if (false_label_ != fall_through_) __ Branch(false_label_); 549 if (false_label_ != fall_through_) __ Branch(false_label_);
(...skipping 3271 matching lines...) Expand 10 before | Expand all | Expand 10 after
3820 reinterpret_cast<uint32_t>( 3821 reinterpret_cast<uint32_t>(
3821 isolate->builtins()->OnStackReplacement()->entry())); 3822 isolate->builtins()->OnStackReplacement()->entry()));
3822 return ON_STACK_REPLACEMENT; 3823 return ON_STACK_REPLACEMENT;
3823 } 3824 }
3824 3825
3825 3826
3826 } // namespace internal 3827 } // namespace internal
3827 } // namespace v8 3828 } // namespace v8
3828 3829
3829 #endif // V8_TARGET_ARCH_MIPS 3830 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698