Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2043173002: Fix LUB computation in face of errors in code (issue 26631) (Closed)

Created:
4 years, 6 months ago by Brian Wilkerson
Modified:
4 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, Leaf
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix LUB computation in face of errors in code (issue 26631) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/27c0eeb0b20bafc3035014e20faa6da5adedbf0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_analyzer_test.dart View 2 chunks +32 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 6 months ago (2016-06-07 22:16:22 UTC) #2
scheglov
LGTM
4 years, 6 months ago (2016-06-08 00:42:13 UTC) #3
Brian Wilkerson
4 years, 6 months ago (2016-06-08 14:54:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
27c0eeb0b20bafc3035014e20faa6da5adedbf0f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698