Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2043153003: Implement "create an element" when async for Custom Element V1 (Closed)

Created:
4 years, 6 months ago by kojii
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement "create an element" when async for Custom Element V1 This patch implements "create an element" concept[1] step 6.2, when synchronous custom elements flag is unset. [1] https://dom.spec.whatwg.org/#concept-create-element BUG=594918 Committed: https://crrev.com/c270081c630097becbb6934cfb85b6f73bdd409c Cr-Commit-Position: refs/heads/master@{#398834}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/custom-elements/spec/create-element-defined-asynchronous.html View 1 chunk +79 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElement.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElement.cpp View 5 chunks +40 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
kojii
PTAL.
4 years, 6 months ago (2016-06-08 17:07:44 UTC) #5
kojii
A gentle reminder, PTAL this one too.
4 years, 6 months ago (2016-06-09 06:46:26 UTC) #6
dominicc (has gone to gerrit)
lgtm LGTM, v. exciting to see CEReactions in action.
4 years, 6 months ago (2016-06-09 07:50:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043153003/20001
4 years, 6 months ago (2016-06-09 07:50:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/84885)
4 years, 6 months ago (2016-06-09 08:30:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043153003/20001
4 years, 6 months ago (2016-06-09 09:30:54 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-09 10:35:58 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 10:37:23 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c270081c630097becbb6934cfb85b6f73bdd409c
Cr-Commit-Position: refs/heads/master@{#398834}

Powered by Google App Engine
This is Rietveld 408576698