xfa/fxfa/parser/xfa_script_resolveprocessor.cpp - Issue 2043153002: Remove various FXJSE Value methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_script_resolveprocessor.cpp

Issue 2043153002: Remove various FXJSE Value methods. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_script_resolveprocessor.cpp

diff --git a/xfa/fxfa/parser/xfa_script_resolveprocessor.cpp b/xfa/fxfa/parser/xfa_script_resolveprocessor.cpp

index 6be5bd03e67c1d3b55b9e0357465fa613d179e2a..c2101f7719afe6199235cbb3213321b1eb68ea63 100644

--- a/xfa/fxfa/parser/xfa_script_resolveprocessor.cpp

+++ b/xfa/fxfa/parser/xfa_script_resolveprocessor.cpp

@@ -712,7 +712,7 @@ void CXFA_ResolveProcessor::XFA_ResolveNode_DoPredicateFilter(

new CFXJSE_Value(rnd.m_pSC->GetRuntime()));

bRet = pContext->RunScript(eLangType, wsExpression.AsStringC(),

pRetValue.get(), node);

- if (!bRet || !FXJSE_Value_ToBoolean(pRetValue.get()))

+ if (!bRet || !pRetValue->ToBoolean())

findNodes.RemoveAt(i);

}