xfa/fxfa/app/xfa_ffnotify.cpp - Issue 2043153002: Remove various FXJSE Value methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_ffnotify.cpp

Issue 2043153002: Remove various FXJSE Value methods. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/app/xfa_ffnotify.cpp

diff --git a/xfa/fxfa/app/xfa_ffnotify.cpp b/xfa/fxfa/app/xfa_ffnotify.cpp

index 9524a25b1a88685d4b99fd3f56f64d15c96dd088..c801bb45e546639cad0b6130b3a99d40c472494e 100644

--- a/xfa/fxfa/app/xfa_ffnotify.cpp

+++ b/xfa/fxfa/app/xfa_ffnotify.cpp

@@ -206,7 +206,7 @@ FX_BOOL CXFA_FFNotify::RunScript(CXFA_Node* pScript, CXFA_Node* pFormItem) {

int32_t iRet =

pWidgetAcc->ExecuteScript(CXFA_Script(pScript), &EventParam, &pRetValue);

if (iRet == XFA_EVENTERROR_Success && pRetValue) {

- bRet = FXJSE_Value_ToBoolean(pRetValue);

+ bRet = pRetValue->ToBoolean();

delete pRetValue;

}

return bRet;

« no previous file with comments | « fpdfsdk/javascript/cjs_runtime.cpp ('k') | xfa/fxfa/app/xfa_ffwidgetacc.cpp » ('j') | no next file with comments »