fpdfsdk/javascript/cjs_runtime.cpp - Issue 2043153002: Remove various FXJSE Value methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/cjs_runtime.cpp

Issue 2043153002: Remove various FXJSE Value methods. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/cjs_runtime.cpp

diff --git a/fpdfsdk/javascript/cjs_runtime.cpp b/fpdfsdk/javascript/cjs_runtime.cpp

index 2c0ed32bd677cdbee33f8742fe22bad1f7e8f9c8..1e65b6db7e00b4b8d73785eee4335ba21a78e1c9 100644

--- a/fpdfsdk/javascript/cjs_runtime.cpp

+++ b/fpdfsdk/javascript/cjs_runtime.cpp

@@ -277,7 +277,7 @@ FX_BOOL CJS_Runtime::GetValueByName(const CFX_ByteStringC& utf8Name,

GetIsolate(), name, v8::String::kNormalString, utf8Name.GetLength()));

if (propvalue.IsEmpty()) {

- FXJSE_Value_SetUndefined(pValue);

+ pValue->SetUndefined();

return FALSE;

}

pValue->ForceSetValue(propvalue);

« no previous file with comments | « no previous file | xfa/fxfa/app/xfa_ffnotify.cpp » ('j') | xfa/fxfa/app/xfa_ffwidgetacc.cpp » ('J')