neon64 use width int directly.

neon64 use width int directly.

width %w size modifier the int width can be passed directly to arm assembly.
For functions that take input constants, the outputs are declared as early
write using &, meaning the outputs use used before all inputs are consumed.

R=harryjin@google.com
BUG=libyuv:598
Committed: https://chromium.googlesource.com/libyuv/libyuv/+/026be3cd850d086dc24a792ae4f777e2b83533b7

[fbarchard1, 2016-06-07 19:17:21]

Was
$ git cl lint
Done processing source/row_neon.cc
source/row_neon64.cc:566:  Using C-style cast.  Use static_cast<int64>(...)
instead  [readability/casting] [4]
source/row_neon64.cc:593:  Using C-style cast.  Use static_cast<int64>(...)
instead  [readability/casting] [4]
source/row_neon64.cc:711:  Using C-style cast.  Use static_cast<int64>(...)
instead  [readability/casting] [4]
source/row_neon64.cc:737:  Using C-style cast.  Use static_cast<int64>(...)
instead  [readability/casting] [4]
source/row_neon64.cc:764:  Using C-style cast.  Use static_cast<int64>(...)
instead  [readability/casting] [4]
Done processing source/row_neon64.cc
Total errors found: 5

Now
$ git cl lint
Done processing source/row_neon64.cc
Total errors found: 0

[fbarchard1, 2016-06-07 19:18:05]

Description was changed from

==========
neon64 use width int directly.

width %w size modifier the int width can be passed directly to arm assembly.
For functions that take input constants, the outputs are declared as early
write using &, meaning the outputs use used before all inputs are consumed.

R=harryjin@google.com
BUG=libyuv:598
==========

to

==========
neon64 use width int directly.

width %w size modifier the int width can be passed directly to arm assembly.
For functions that take input constants, the outputs are declared as early
write using &, meaning the outputs use used before all inputs are consumed.

R=harryjin@google.com
BUG=libyuv:598
==========

[fbarchard1, 2016-06-07 22:24:48]

fbarchard@google.com changed reviewers:
+ wangcheng@google.com

[fbarchard1, 2016-06-07 22:24:50]

https://codereview.chromium.org/2043073003/diff/80001/source/row_neon64.cc
File source/row_neon64.cc (right):

https://codereview.chromium.org/2043073003/diff/80001/source/row_neon64.cc#ne...
source/row_neon64.cc:756: src += width * 4 - 16;
Code generated is:

0000000000000000 <ARGBMirrorRow_NEON>:
   0:	51001043 	sub	w3, w2, #0x4
   4:	531e7463 	lsl	w3, w3, #2
   8:	8b23c000 	add	x0, x0, w3, sxtw
   c:	928001e3 	mov	x3, #0xfffffffffffffff0    	// #-16
  10:	4cc37000 	ld1	{v0.16b}, [x0], x3
  14:	71001042 	subs	w2, w2, #0x4
  18:	4ea00800 	rev64	v0.4s, v0.4s
  1c:	4d9f8420 	st1	{v0.d}[1], [x1], #8
  20:	0d9f8420 	st1	{v0.d}[0], [x1], #8
  24:	54ffff6c 	b.gt	10 <ARGBMirrorRow_NEON+0x10>
  28:	d65f03c0 	ret

could
   4:	531e7463 	lsl	w3, w3, #2
   8:	8b23c000 	add	x0, x0, w3, sxtw

be replaced with:?
   8:	8b23c000 	add	x0, x0, w3, sxtw #2

[fbarchard1, 2016-06-08 01:27:54]

removed trailing tab on comment, adjusted indent on subs

[fbarchard1, 2016-06-08 01:32:52]

fbarchard@google.com changed reviewers:
+ kjellander@chromium.org

[harryjin, 2016-06-08 02:02:24]

lgtm

[fbarchard1, 2016-06-08 17:26:57]

Description was changed from

==========
neon64 use width int directly.

width %w size modifier the int width can be passed directly to arm assembly.
For functions that take input constants, the outputs are declared as early
write using &, meaning the outputs use used before all inputs are consumed.

R=harryjin@google.com
BUG=libyuv:598
==========

to

==========
neon64 use width int directly.

width %w size modifier the int width can be passed directly to arm assembly.
For functions that take input constants, the outputs are declared as early
write using &, meaning the outputs use used before all inputs are consumed.

R=harryjin@google.com
BUG=libyuv:598

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/026be3cd850d086dc24a792ae4f...
==========

[fbarchard1, 2016-06-08 17:26:58]

Committed patchset #8 (id:140001) manually as
026be3cd850d086dc24a792ae4f777e2b83533b7 (presubmit successful).