Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.h

Issue 2043033002: Trace ScriptWrappableVisitor.m_markingDeque by oilpan gc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Only record wrappers when tracing Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/ThreadState.h
diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.h b/third_party/WebKit/Source/platform/heap/ThreadState.h
index 456d154a3a689c083b227afc911945329f6f0716..a2612d7252af8783a81aaf34159b9a8c9d3810d8 100644
--- a/third_party/WebKit/Source/platform/heap/ThreadState.h
+++ b/third_party/WebKit/Source/platform/heap/ThreadState.h
@@ -424,6 +424,15 @@ public:
m_traceDOMWrappers = traceDOMWrappers;
}
+ void registerTraceWrappersMarkingDequeTracing(v8::Isolate* isolate,
+ void (*traceWrappersMarkingDequeTracing)(v8::Isolate*, Visitor*))
+ {
+ // Make sure the isolate set by registerTraceDOMWrapers is the same as
haraken 2016/06/08 08:56:08 Or can we merge the two register functions?
+ // ours
+ CHECK(m_isolate == isolate);
+ m_traceWrappersMarkingDequeTracing = traceWrappersMarkingDequeTracing;
+ }
+
// By entering a gc-forbidden scope, conservative GCs will not
// be allowed while handling an out-of-line allocation request.
// Intended used when constructing subclasses of GC mixins, where
@@ -656,6 +665,7 @@ private:
v8::Isolate* m_isolate;
void (*m_traceDOMWrappers)(v8::Isolate*, Visitor*);
+ void (*m_traceWrappersMarkingDequeTracing)(v8::Isolate*, Visitor*);
#if defined(ADDRESS_SANITIZER)
void* m_asanFakeStack;

Powered by Google App Engine
This is Rietveld 408576698