third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp - Issue 2043033002: Trace ScriptWrappableVisitor.m_markingDeque by oilpan gc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

Issue 2043033002: Trace ScriptWrappableVisitor.m_markingDeque by oilpan gc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix callers of registerTraceDOMWrappers Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

index f11dc8f08978234b286813c24ba4e3418207515b..bdf76edfc2536574abceed985a63be93a34d6d4f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

@@ -370,11 +370,11 @@ bool WindowProxy::setupWindowPrototypeChain()

// The prototype object of Window interface.

v8::Local<v8::Object> windowPrototype = windowWrapper->GetPrototype().As<v8::Object>();

RELEASE_ASSERT(!windowPrototype.IsEmpty());

- V8DOMWrapper::setNativeInfo(windowPrototype, wrapperTypeInfo, window);

+ V8DOMWrapper::setNativeInfo(m_isolate, windowPrototype, wrapperTypeInfo, window);

// The named properties object of Window interface.

v8::Local<v8::Object> windowProperties = windowPrototype->GetPrototype().As<v8::Object>();

RELEASE_ASSERT(!windowProperties.IsEmpty());

- V8DOMWrapper::setNativeInfo(windowProperties, wrapperTypeInfo, window);

+ V8DOMWrapper::setNativeInfo(m_isolate, windowProperties, wrapperTypeInfo, window);

// TODO(keishi): Remove installPagePopupController and implement

// PagePopupController in another way.