third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp - Issue 2043033002: Trace ScriptWrappableVisitor.m_markingDeque by oilpan gc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2043033002: Trace ScriptWrappableVisitor.m_markingDeque by oilpan gc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix callers of registerTraceDOMWrappers Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h ('k') | third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

index 1879f9d9d48e4418f904e75c22ab1c0e43df929d..68f47f322817a4a20bf0b42176e7b9f68f86d5da 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

@@ -366,7 +366,15 @@ void V8Initializer::initializeMainThread()

ASSERT(ThreadState::mainThreadState());

ThreadState::mainThreadState()->addInterruptor(adoptPtr(new V8IsolateInterruptor(isolate)));

- ThreadState::mainThreadState()->registerTraceDOMWrappers(isolate, V8GCController::traceDOMWrappers);

+ if (RuntimeEnabledFeatures::traceWrappablesEnabled()) {

+ ThreadState::mainThreadState()->registerTraceDOMWrappers(isolate,

+ V8GCController::traceDOMWrappers,

+ ScriptWrappableVisitor::invalidateDeadObjectsInMarkingDeque);

+ } else {

+ ThreadState::mainThreadState()->registerTraceDOMWrappers(isolate,

+ V8GCController::traceDOMWrappers,

+ nullptr);

+ }

V8PerIsolateData::from(isolate)->setThreadDebugger(adoptPtr(new MainThreadDebugger(isolate)));

}