Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2042983002: Deploy Nexus 5X config to tryserver.chromium.angle and Nexus 6P to gpu.fyi. (Closed)

Created:
4 years, 6 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, ynovikov
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Deploy Nexus 5X config to tryserver.chromium.angle and Nexus 6P to gpu.fyi. BUG=490984, 617848 Committed: https://chromium.googlesource.com/chromium/tools/build/+/162b59ad24969c8dee657560c32877a67fd7891d

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -11 lines) Patch
M masters/master.chromium.gpu.fyi/slaves.cfg View 1 chunk +12 lines, -1 line 0 comments Download
M masters/master.tryserver.chromium.angle/master.cfg View 2 chunks +9 lines, -0 lines 0 comments Download
M masters/master.tryserver.chromium.angle/slaves.cfg View 2 chunks +21 lines, -1 line 2 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py View 1 chunk +25 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/trybots.py View 1 chunk +4 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Android_Debug__Nexus_6P_.json View 3 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_android_angle_dbg_ng.json View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ken Russell (switch to Gerrit)
dpranke or phajdan.jr: please review. Thanks. ynovikov: FYI.
4 years, 6 months ago (2016-06-07 05:46:49 UTC) #2
Paweł Hajdan Jr.
LGTM
4 years, 6 months ago (2016-06-07 10:50:51 UTC) #3
ynovikov
https://codereview.chromium.org/2042983002/diff/1/masters/master.tryserver.chromium.angle/slaves.cfg File masters/master.tryserver.chromium.angle/slaves.cfg (right): https://codereview.chromium.org/2042983002/diff/1/masters/master.tryserver.chromium.angle/slaves.cfg#newcode8 masters/master.tryserver.chromium.angle/slaves.cfg:8: angle_android_slaves = range(768,773) I think this should be (768,772), ...
4 years, 6 months ago (2016-06-07 19:33:18 UTC) #5
ynovikov
https://codereview.chromium.org/2042983002/diff/1/masters/master.tryserver.chromium.angle/slaves.cfg File masters/master.tryserver.chromium.angle/slaves.cfg (right): https://codereview.chromium.org/2042983002/diff/1/masters/master.tryserver.chromium.angle/slaves.cfg#newcode8 masters/master.tryserver.chromium.angle/slaves.cfg:8: angle_android_slaves = range(768,773) On 2016/06/07 19:33:18, ynovikov wrote: > ...
4 years, 6 months ago (2016-06-07 19:39:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042983002/1
4 years, 6 months ago (2016-06-07 21:01:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/162b59ad24969c8dee657560c32877a67fd7891d
4 years, 6 months ago (2016-06-07 21:05:19 UTC) #10
Dirk Pranke
4 years, 6 months ago (2016-06-07 22:18:31 UTC) #11
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698