Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8711)

Unified Diff: chrome/browser/resources/md_history/side_bar.html

Issue 2042973002: [MD History] Add routing to the synced devices page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hide_search_bar
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/side_bar.html
diff --git a/chrome/browser/resources/md_history/side_bar.html b/chrome/browser/resources/md_history/side_bar.html
index 37bdc02db0d55a2a3659593ffa17cdc5492d52c8..045bcf3f555479e2ce05305b157e2cf633ca2f6b 100644
--- a/chrome/browser/resources/md_history/side_bar.html
+++ b/chrome/browser/resources/md_history/side_bar.html
@@ -1,8 +1,9 @@
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/polymer/v1_0/app-layout/app-drawer/app-drawer.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-flex-layout.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-selector/iron-selector.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/typography.html">
<link rel="import" href="chrome://history/browser_service.html">
<link rel="import" href="chrome://history/shared_style.html">
@@ -40,14 +41,43 @@
text-transform: uppercase;
}
- paper-item {
+ iron-selector {
+ -webkit-user-select: none;
+ background-color: transparent;
+ color: #5a5a5a;
+ }
+
+ iron-selector a {
+ @apply(--paper-font-subhead);
-webkit-padding-start: 25px;
+ align-items: center;
+ box-sizing: border-box;
+ color: inherit;
cursor: pointer;
+ display: flex;
font-size: 14px;
font-weight: 500;
+ min-height: 48px;
+ outline: none;
+ position: relative;
+ text-decoration: none;
+ }
+
+ iron-selector a:focus {
+ outline: 0;
+ position: relative;
+ }
+
+ iron-selector a:focus::before {
+ @apply(--layout-fit);
+
+ background: currentColor;
+ content: '';
+ opacity: var(--dark-divider-opacity);
+ pointer-events: none;
}
- paper-item.iron-selected {
+ iron-selector a.iron-selected {
color: var(--google-blue-500);
font-weight: 500;
}
@@ -64,18 +94,20 @@
<h1>$i18n{title}</h1>
</div>
<iron-selector id="menu" selected="{{selectedPage}}"
- selectable=".page-item" attr-for-selected="view-id"
+ selectable=".page-item" attr-for-selected="path"
+ fallback-selection="history"
on-iron-activate="onSelectorActivate_">
- <paper-item view-id="history" class="page-item">
+ <a href="/" class="page-item" path="history">
$i18n{historyMenuItem}
- </paper-item>
- <paper-item view-id="synced-devices" class="page-item">
+ </a>
+ <a href="/syncedTabs" class="page-item" path="syncedTabs">
$i18n{openTabsMenuItem}
- </paper-item>
+ </a>
<div class="separator"></div>
- <paper-item on-tap="onClearBrowsingDataTap_" id="clear-browsing-data">
+ <a href="chrome://settings/clearBrowserData"
+ on-tap="onClearBrowsingDataTap_" id="clear-browsing-data">
$i18n{clearBrowsingData}
- </paper-item>
+ </a>
</iron-selector>
</app-drawer>
</template>

Powered by Google App Engine
This is Rietveld 408576698