chrome/browser/resources/md_history/side_bar.html - Issue 2042973002: [MD History] Add routing to the synced devices page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/side_bar.html

Issue 2042973002: [MD History] Add routing to the synced devices page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hide_search_bar

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/app.js ('K') | « chrome/browser/resources/md_history/history.html ('k') | chrome/browser/resources/md_history/side_bar.js » ('j') | ui/webui/resources/polymer_resources.grdp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/side_bar.html

diff --git a/chrome/browser/resources/md_history/side_bar.html b/chrome/browser/resources/md_history/side_bar.html

index 2b17e38a8ac47c307b9803c726d6dca1d2e3c5c2..3d3730e10dfb9278d39fb397b1d5df5af94c976a 100644

--- a/chrome/browser/resources/md_history/side_bar.html

+++ b/chrome/browser/resources/md_history/side_bar.html

@@ -42,13 +42,15 @@

color: #5a5a5a;

}

</style>

- <paper-listbox id="overflow-menu" selected="0" on-iron-select="onSelect_"

+ <paper-listbox id="menu" selected="[[routeData.page]]"

tsergeant 2016/06/08 03:42:17 Should this be 2-way bound?

calamity 2016/06/14 05:05:50 Nah.

+ attr-for-selected="path" on-iron-select="onSelect_"

selectable=".page-item">

- <paper-item view-id="history-list" class="page-item">

+ <paper-item view-id="history-list" class="page-item" path="">

tsergeant 2016/06/08 03:42:18 This element has a bunch of extra logic to work wi

calamity 2016/06/14 05:05:50 Done.

<div>$i18n{historyMenuItem}</div>

<paper-ripple></paper-ripple>

</paper-item>

- <paper-item view-id="history-synced-device-manager" class="page-item">

+ <paper-item view-id="history-synced-device-manager" class="page-item"

+ path="openTabs">

<div>$i18n{openTabsMenuItem}</div>

<paper-ripple></paper-ripple>

</paper-item>