Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6608)

Unified Diff: chrome/browser/resources/md_history/app.html

Issue 2042973002: [MD History] Add routing to the synced devices page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hide_search_bar
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/app.html
diff --git a/chrome/browser/resources/md_history/app.html b/chrome/browser/resources/md_history/app.html
index 9085a41ea87fc2c0e504657a5300dda5dc2bb2a9..c776738648e33061d10c98d38bf0c7310fbb06df 100644
--- a/chrome/browser/resources/md_history/app.html
+++ b/chrome/browser/resources/md_history/app.html
@@ -7,6 +7,8 @@
<link rel="import" href="chrome://history/synced_device_manager.html">
<link rel="import" href="chrome://history/side_bar.html">
<link rel="import" href="chrome://history/shared_style.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/app-route/app-location.html">
tsergeant 2016/06/08 03:42:17 Nit: Sort imports
calamity 2016/06/14 05:05:50 Done.
+<link rel="import" href="chrome://resources/polymer/v1_0/app-route/app-route.html">
<link rel="stylesheet" href="chrome://resources/css/md_colors.css">
<dom-module id="history-app">
@@ -42,6 +44,10 @@
overflow: hidden;
}
</style>
+
+ <app-location route="{{route}}"></app-location>
+ <app-route route="{{route}}" pattern="/:page" data="{{routeData}}">
+ </app-route>
<history-toolbar id="toolbar" searching="[[queryState_.querying]]"
is-grouped-mode="{{grouped_}}"
grouped-range="{{queryState_.range}}"
@@ -51,7 +57,8 @@
</history-toolbar>
<div id="main-container">
- <history-side-bar id="history-side-bar" selected-page="{{selectedPage_}}">
+ <history-side-bar id="history-side-bar" selected-page="{{selectedPage}}"
tsergeant 2016/06/08 03:42:17 The history-app property is called `selectedPage_`
calamity 2016/06/14 05:05:50 Done.
+ route-data="{{routeData}}">`
tsergeant 2016/06/08 03:42:17 There's a sneaky ` character hiding out here.
calamity 2016/06/14 05:05:50 Done.
</history-side-bar>
<iron-pages id="content" attr-for-selected="id"
selected="[[getSelectedPage(selectedPage_, queryState_.range)]]">
« no previous file with comments | « no previous file | chrome/browser/resources/md_history/app.js » ('j') | chrome/browser/resources/md_history/app.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698