Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h

Issue 2042943003: Move CSSValue->CSSStyleValue logic out of StylePropertyMap and into the StyleValueFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stylevaue
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef StylePropertyMap_h 5 #ifndef StylePropertyMap_h
6 #define StylePropertyMap_h 6 #define StylePropertyMap_h
7 7
8 #include "bindings/core/v8/CSSStyleValueOrCSSStyleValueSequence.h" 8 #include "bindings/core/v8/CSSStyleValueOrCSSStyleValueSequence.h"
9 #include "bindings/core/v8/CSSStyleValueOrCSSStyleValueSequenceOrString.h" 9 #include "bindings/core/v8/CSSStyleValueOrCSSStyleValueSequenceOrString.h"
10 #include "bindings/core/v8/Iterable.h" 10 #include "bindings/core/v8/Iterable.h"
11 #include "bindings/core/v8/ScriptWrappable.h" 11 #include "bindings/core/v8/ScriptWrappable.h"
12 #include "core/CSSPropertyNames.h" 12 #include "core/CSSPropertyNames.h"
13 #include "core/CoreExport.h" 13 #include "core/CoreExport.h"
14 #include "core/css/cssom/CSSStyleValue.h" 14 #include "core/css/cssom/CSSStyleValue.h"
15 15
16 namespace blink { 16 namespace blink {
17 17
18 class ExceptionState; 18 class ExceptionState;
19 19
20 class CORE_EXPORT StylePropertyMap : public GarbageCollectedFinalized<StylePrope rtyMap>, public ScriptWrappable, public PairIterable<String, CSSStyleValueOrCSSS tyleValueSequence> { 20 class CORE_EXPORT StylePropertyMap : public GarbageCollectedFinalized<StylePrope rtyMap>, public ScriptWrappable, public PairIterable<String, CSSStyleValueOrCSSS tyleValueSequence> {
21 WTF_MAKE_NONCOPYABLE(StylePropertyMap); 21 WTF_MAKE_NONCOPYABLE(StylePropertyMap);
22 DEFINE_WRAPPERTYPEINFO(); 22 DEFINE_WRAPPERTYPEINFO();
23 public: 23 public:
24 typedef HeapVector<Member<CSSStyleValue>> StyleValueVector;
25 typedef std::pair<String, CSSStyleValueOrCSSStyleValueSequence> StylePropert yMapEntry; 24 typedef std::pair<String, CSSStyleValueOrCSSStyleValueSequence> StylePropert yMapEntry;
26 25
27 virtual ~StylePropertyMap() { } 26 virtual ~StylePropertyMap() { }
28 27
29 // Accessors. 28 // Accessors.
30 CSSStyleValue* get(const String& propertyName, ExceptionState&); 29 CSSStyleValue* get(const String& propertyName, ExceptionState&);
31 StyleValueVector getAll(const String& propertyName, ExceptionState&); 30 CSSStyleValueVector getAll(const String& propertyName, ExceptionState&);
32 bool has(const String& propertyName, ExceptionState&); 31 bool has(const String& propertyName, ExceptionState&);
33 32
34 virtual StyleValueVector getAll(CSSPropertyID) = 0; 33 virtual CSSStyleValueVector getAll(CSSPropertyID) = 0;
35 virtual Vector<String> getProperties() = 0; 34 virtual Vector<String> getProperties() = 0;
36 35
37 // Modifiers. 36 // Modifiers.
38 void set(const String& propertyName, CSSStyleValueOrCSSStyleValueSequenceOrS tring& item, ExceptionState&); 37 void set(const String& propertyName, CSSStyleValueOrCSSStyleValueSequenceOrS tring& item, ExceptionState&);
39 void append(const String& propertyName, CSSStyleValueOrCSSStyleValueSequence OrString& item, ExceptionState&); 38 void append(const String& propertyName, CSSStyleValueOrCSSStyleValueSequence OrString& item, ExceptionState&);
40 void remove(const String& propertyName, ExceptionState&); 39 void remove(const String& propertyName, ExceptionState&);
41 40
42 virtual void set(CSSPropertyID, CSSStyleValueOrCSSStyleValueSequenceOrString & item, ExceptionState&) = 0; 41 virtual void set(CSSPropertyID, CSSStyleValueOrCSSStyleValueSequenceOrString & item, ExceptionState&) = 0;
43 virtual void append(CSSPropertyID, CSSStyleValueOrCSSStyleValueSequenceOrStr ing& item, ExceptionState&) = 0; 42 virtual void append(CSSPropertyID, CSSStyleValueOrCSSStyleValueSequenceOrStr ing& item, ExceptionState&) = 0;
44 virtual void remove(CSSPropertyID, ExceptionState&) = 0; 43 virtual void remove(CSSPropertyID, ExceptionState&) = 0;
45 44
46 DEFINE_INLINE_VIRTUAL_TRACE() { } 45 DEFINE_INLINE_VIRTUAL_TRACE() { }
47 46
48 protected: 47 protected:
49 StylePropertyMap() { } 48 StylePropertyMap() { }
50 49
51 virtual HeapVector<StylePropertyMapEntry> getIterationEntries() = 0; 50 virtual HeapVector<StylePropertyMapEntry> getIterationEntries() = 0;
52 IterationSource* startIteration(ScriptState*, ExceptionState&) override; 51 IterationSource* startIteration(ScriptState*, ExceptionState&) override;
53 StyleValueVector cssValueToStyleValueVector(CSSPropertyID, const CSSValue&);
54 }; 52 };
55 53
56 } // namespace blink 54 } // namespace blink
57 55
58 #endif 56 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698