Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2042933002: document cpuid command line behavior (Closed)

Created:
4 years, 6 months ago by fbarchard1
Modified:
4 years, 6 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

document cpuid command line behavior cpu_info_ is zero for uninitialized state and all bits are off, disabling all cpu optimizations. the 1 bit indicates cpu_info_ is initialized avoiding calling the detection code again for performance. MaskCpuFlags initializes the cpu ignoring existing flags, then masks with the supplied flags and stores to cpu_info_. As a mask, -1 has no effect, enabling all cpu features that were detected, but nothing that wasnt detected. Setting to 0 will cause the next call to re-initialize the cpu, which is same as enabling all features. Setting mask to 1 will turn off all cpu features but keep the initialized bit on, so the next detection call wont reinitialize and the cpu features are all disabled. So normal behavior for command line and programatic masking is: 1 = C -1 = SIMD TBR=harryjin@google.com BUG=libyuv:600 TESTED=out64/Release/bin/run_libyuv_unittest -s libyuv_unittest --verbose --release --gtest_filter=*ARGBExtractAlpha* -a "--libyuv_width=1280 --libyuv_height=720 --libyuv_repeat=9999 --libyuv_flags=1 --libyuv_cpu_info=1" Committed: https://chromium.googlesource.com/libyuv/libyuv/+/e2611a734955782ac9be1a64d080a6e52a57be82

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : command line flags init to 0 #

Patch Set 4 : rebased #

Patch Set 5 : white space fixes in unittest #

Patch Set 6 : rebased #

Patch Set 7 : bump version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M README.chromium View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M docs/getting_started.md View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/cpu_id.h View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M unit_test/unit_test.cc View 1 2 3 4 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
fbarchard1
lint passed. local build passes. try bots pass.
4 years, 6 months ago (2016-06-08 17:37:26 UTC) #7
fbarchard1
4 years, 6 months ago (2016-06-08 17:38:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
e2611a734955782ac9be1a64d080a6e52a57be82 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698