Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: src/a64/debug-a64.cc

Issue 204293004: A64: Remove Operand constructors where an implicit constructor can be used. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/codegen-a64.cc ('k') | src/a64/deoptimizer-a64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 } 195 }
196 196
197 if (object_regs != 0) { 197 if (object_regs != 0) {
198 __ PushXRegList(object_regs); 198 __ PushXRegList(object_regs);
199 } 199 }
200 200
201 #ifdef DEBUG 201 #ifdef DEBUG
202 __ RecordComment("// Calling from debug break to runtime - come in - over"); 202 __ RecordComment("// Calling from debug break to runtime - come in - over");
203 #endif 203 #endif
204 __ Mov(x0, 0); // No arguments. 204 __ Mov(x0, 0); // No arguments.
205 __ Mov(x1, Operand(ExternalReference::debug_break(masm->isolate()))); 205 __ Mov(x1, ExternalReference::debug_break(masm->isolate()));
206 206
207 CEntryStub stub(1); 207 CEntryStub stub(1);
208 __ CallStub(&stub); 208 __ CallStub(&stub);
209 209
210 // Restore the register values from the expression stack. 210 // Restore the register values from the expression stack.
211 if (object_regs != 0) { 211 if (object_regs != 0) {
212 __ PopXRegList(object_regs); 212 __ PopXRegList(object_regs);
213 } 213 }
214 214
215 non_object_list = 215 non_object_list =
(...skipping 11 matching lines...) Expand all
227 } 227 }
228 228
229 // Leave the internal frame. 229 // Leave the internal frame.
230 } 230 }
231 231
232 // Now that the break point has been handled, resume normal execution by 232 // Now that the break point has been handled, resume normal execution by
233 // jumping to the target address intended by the caller and that was 233 // jumping to the target address intended by the caller and that was
234 // overwritten by the address of DebugBreakXXX. 234 // overwritten by the address of DebugBreakXXX.
235 ExternalReference after_break_target(Debug_Address::AfterBreakTarget(), 235 ExternalReference after_break_target(Debug_Address::AfterBreakTarget(),
236 masm->isolate()); 236 masm->isolate());
237 __ Mov(scratch, Operand(after_break_target)); 237 __ Mov(scratch, after_break_target);
238 __ Ldr(scratch, MemOperand(scratch)); 238 __ Ldr(scratch, MemOperand(scratch));
239 __ Br(scratch); 239 __ Br(scratch);
240 } 240 }
241 241
242 242
243 void Debug::GenerateLoadICDebugBreak(MacroAssembler* masm) { 243 void Debug::GenerateLoadICDebugBreak(MacroAssembler* masm) {
244 // Calling convention for IC load (from ic-arm.cc). 244 // Calling convention for IC load (from ic-arm.cc).
245 // ----------- S t a t e ------------- 245 // ----------- S t a t e -------------
246 // -- x2 : name 246 // -- x2 : name
247 // -- lr : return address 247 // -- lr : return address
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 masm->Abort(kLiveEditFrameDroppingIsNotSupportedOnA64); 384 masm->Abort(kLiveEditFrameDroppingIsNotSupportedOnA64);
385 } 385 }
386 386
387 const bool Debug::kFrameDropperSupported = false; 387 const bool Debug::kFrameDropperSupported = false;
388 388
389 #endif // ENABLE_DEBUGGER_SUPPORT 389 #endif // ENABLE_DEBUGGER_SUPPORT
390 390
391 } } // namespace v8::internal 391 } } // namespace v8::internal
392 392
393 #endif // V8_TARGET_ARCH_A64 393 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « src/a64/codegen-a64.cc ('k') | src/a64/deoptimizer-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698