Make GrDashEffect take a AA mode enum.

Make GrDashEffect take a AA mode enum.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2042923003

Committed: https://skia.googlesource.com/skia/+/af18fb49fbefb96a6670171a07442b1ccb9f746f

[bsalomon, 2016-06-07 14:43:45]

Description was changed from

==========
Make GrDashEffect take a AA mode enum.
==========

to

==========
Make GrDashEffect take a AA mode enum.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2042923003
==========

[bsalomon, 2016-06-07 14:52:41]

bsalomon@google.com changed reviewers:
+ csmartdalton@google.com, egdaniel@google.com

[bsalomon, 2016-06-07 14:53:15]

I think this more clearly captures the set of intended use cases WRT to AA for
GrDashingEffect.

[egdaniel, 2016-06-07 14:57:23]

lgtm

[bsalomon, 2016-06-07 14:57:43]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-06-07 14:57:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042923003/40001

[csmartdalton, 2016-06-07 15:04:32]

https://codereview.chromium.org/2042923003/diff/40001/src/gpu/batches/GrDashL...
File src/gpu/batches/GrDashLinePathRenderer.cpp (right):

https://codereview.chromium.org/2042923003/diff/40001/src/gpu/batches/GrDashL...
src/gpu/batches/GrDashLinePathRenderer.cpp:47: GrPipelineBuilder
pipelineBuilder(*args.fPaint, msaaIsEnabled);
Just an FYI-- The patch doesn't introduce a change in functionality that I can
see, but until
https://codereview.chromium.org/2041283002/, that second parameter to the
constructor is just one element to GrPB's formula about whether it should enable
hwaa.

So for now we are still getting into a weird, half AA half non-AA state when
support to disable MSAA exists. Because the PB will disable HWAA when
paint.isAntiAlias() is false.

[commit-bot: I haz the power, 2016-06-07 15:10:49]

Description was changed from

==========
Make GrDashEffect take a AA mode enum.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2042923003
==========

to

==========
Make GrDashEffect take a AA mode enum.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2042923003

Committed:
https://skia.googlesource.com/skia/+/af18fb49fbefb96a6670171a07442b1ccb9f746f
==========

[commit-bot: I haz the power, 2016-06-07 15:10:50]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/af18fb49fbefb96a6670171a07442b1ccb9f746f

[bsalomon, 2016-06-07 15:11:58]

https://codereview.chromium.org/2042923003/diff/40001/src/gpu/batches/GrDashL...
File src/gpu/batches/GrDashLinePathRenderer.cpp (right):

https://codereview.chromium.org/2042923003/diff/40001/src/gpu/batches/GrDashL...
src/gpu/batches/GrDashLinePathRenderer.cpp:47: GrPipelineBuilder
pipelineBuilder(*args.fPaint, msaaIsEnabled);
On 2016/06/07 15:04:32, csmartdalton wrote:
> Just an FYI-- The patch doesn't introduce a change in functionality that I can
> see, but until
> https://codereview.chromium.org/2041283002/, that second parameter to the
> constructor is just one element to GrPB's formula about whether it should
enable
> hwaa.
> 
> So for now we are still getting into a weird, half AA half non-AA state when
> support to disable MSAA exists. Because the PB will disable HWAA when
> paint.isAntiAlias() is false.

But that'll be fixed with your upcoming change right?

[csmartdalton, 2016-06-07 15:13:57]

On 2016/06/07 15:11:58, bsalomon wrote:
>
https://codereview.chromium.org/2042923003/diff/40001/src/gpu/batches/GrDashL...
> File src/gpu/batches/GrDashLinePathRenderer.cpp (right):
> 
>
https://codereview.chromium.org/2042923003/diff/40001/src/gpu/batches/GrDashL...
> src/gpu/batches/GrDashLinePathRenderer.cpp:47: GrPipelineBuilder
> pipelineBuilder(*args.fPaint, msaaIsEnabled);
> On 2016/06/07 15:04:32, csmartdalton wrote:
> > Just an FYI-- The patch doesn't introduce a change in functionality that I
can
> > see, but until
> > https://codereview.chromium.org/2041283002/, that second parameter to the
> > constructor is just one element to GrPB's formula about whether it should
> enable
> > hwaa.
> > 
> > So for now we are still getting into a weird, half AA half non-AA state when
> > support to disable MSAA exists. Because the PB will disable HWAA when
> > paint.isAntiAlias() is false.
> 
> But that'll be fixed with your upcoming change right?

Yeah, I'll take care of it.