Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: ash/common/wm_window.h

Issue 2042913002: Converts MruWindowTracker to work with common types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweaks Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/wm_window.h
diff --git a/ash/common/wm_window.h b/ash/common/wm_window.h
index 8049a09804f05d42a39ce2fc51b5c6093207f960..14cec7f071a882ee2c96880060fc7587af2a2c1f 100644
--- a/ash/common/wm_window.h
+++ b/ash/common/wm_window.h
@@ -54,6 +54,8 @@ class ASH_EXPORT WmWindow {
USE_SCREEN_COORDINATES,
};
+ using Windows = std::vector<WmWindow*>;
James Cook 2016/06/07 01:21:05 optional: I know this is style-guide compliant, an
sky 2016/06/07 02:46:21 I left it for the following reasons: . as you say,
James Cook 2016/06/07 14:05:38 still optional: How about WindowList as a name, th
sky 2016/06/07 15:34:21 I went with Windows because of: https://cs.chromiu
+
WmWindow* GetRootWindow() {
return const_cast<WmWindow*>(
const_cast<const WmWindow*>(this)->GetRootWindow());
@@ -132,7 +134,7 @@ class ASH_EXPORT WmWindow {
const_cast<const WmWindow*>(this)->GetTransientParent());
}
virtual const WmWindow* GetTransientParent() const = 0;
- virtual std::vector<WmWindow*> GetTransientChildren() = 0;
+ virtual Windows GetTransientChildren() = 0;
virtual void SetLayoutManager(
std::unique_ptr<WmLayoutManager> layout_manager) = 0;
@@ -227,7 +229,7 @@ class ASH_EXPORT WmWindow {
virtual void StackChildAbove(WmWindow* child, WmWindow* target) = 0;
virtual void StackChildBelow(WmWindow* child, WmWindow* target) = 0;
- virtual std::vector<WmWindow*> GetChildren() = 0;
+ virtual Windows GetChildren() = 0;
// Shows/hides the resize shadow. |component| is the component to show the
// shadow for (one of the constants in ui/base/hit_test.h).

Powered by Google App Engine
This is Rietveld 408576698