Handle more boolean conversion cases.

Handle more boolean conversion cases.

We were missing boolean conversion checks on logical operators in a
value context.

TBR=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/e11426765e2c06ca320efb1dbcbea00909c6d655

[sra1, 2016-06-07 02:52:08]

Description was changed from

==========
Handle more boolean conversion cases.

We were missing boolean conversion checks on logical operators in a
value context.

TBR=jmesserly@google.com
==========

to

==========
Handle more boolean conversion cases.

We were missing boolean conversion checks on logical operators in a
value context.

TBR=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/e11426765e2c06ca320efb1dbcbe...
==========

[sra1, 2016-06-07 02:52:09]

Committed patchset #1 (id:1) manually as
e11426765e2c06ca320efb1dbcbea00909c6d655 (presubmit successful).

[Jennifer Messerly, 2016-06-07 19:28:35]

lgtm

https://codereview.chromium.org/2042883004/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2042883004/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:3476: return _visitTest(node);
Reading this, I was confused ... my thought was "shouldn't the check be on the
operands, not the result?"

I see that _visitTest is implemented to "push down" the check, so it works. Not
sure if it's worth a comment.

It does seem pretty cool that _visitTest is the place with the knowledge of all
boolean operations. I wonder if _emitBooleanOperation or something like that
might describe its role (just brainstorming ... not sure the right name).