Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2042883003: Fixed right-click/drag bug (Closed)

Created:
4 years, 6 months ago by kylix_rd
Modified:
4 years, 6 months ago
Reviewers:
sky, bruthig
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ink Drop is visibly shown when right-clicking and dragging on the toolbar custom button. According to the report, the button should be non-reactive and show no visible signs of being clicked on. BUG=617764 Committed: https://crrev.com/fa592d3f01a5e00e8de1851b93ebea6593f4c7c3 Cr-Commit-Position: refs/heads/master@{#398316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ui/views/controls/button/custom_button.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
kylix_rd
4 years, 6 months ago (2016-06-06 21:52:57 UTC) #5
bruthig
lgtm
4 years, 6 months ago (2016-06-06 22:29:49 UTC) #6
sky
LGTM
4 years, 6 months ago (2016-06-06 23:23:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042883003/1
4 years, 6 months ago (2016-06-07 16:03:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 17:05:27 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 17:08:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa592d3f01a5e00e8de1851b93ebea6593f4c7c3
Cr-Commit-Position: refs/heads/master@{#398316}

Powered by Google App Engine
This is Rietveld 408576698