Add put/getSourceErrorsInLibrary to IncrementalCache.

Add put/getSourceErrorsInLibrary to IncrementalCache.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/ed8154a53c2357fde3a5adad90e4509a5ab62e8c

[Paul Berry, 2016-06-06 20:03:31]

lgtm

https://codereview.chromium.org/2042883002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):

https://codereview.chromium.org/2042883002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:327: * Return the
[ErrorCode] reference by the given [error], throws if not found.
s/reference/referenced/

https://codereview.chromium.org/2042883002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:331: for (ErrorCode
errorCode in ErrorCode.values) {
I'm concerned that this is going to wind up being a performance bottleneck,
since on average it will have to iterate through 50% of all possible errors in
order to find the matching one.

Consider doing something like this:

final Map<String, ErrorCode> _errorCodeMap = _computeErrorCodeMap();

Map<String, ErrorCode> _computeErrorCodeMap() {
  for (ErrorCode errorCode in ErrorCode.values) {
    _errorCodeMap[errorCode.uniqueName] = errorCode;
  }
}

ErrorCode _getErrorCode(CacheAnalysisError error) {
  String name = '${error.errorCodeClass}.${error.errorCodeField}';
  ErrorCode errorCode = _errorCodeMap[name];
  if (errorCode != null) {
    return errorCode;
  } else {
    throw new StateError(...);
  }
}

https://codereview.chromium.org/2042883002/diff/20001/pkg/analyzer/lib/src/su...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/2042883002/diff/20001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/idl.dart:63: abstract class CacheAnalysisError
extends base.SummaryClass {
I'm having trouble understanding the name of this class.  If what you mean is
"analysis error that has been stored in the cache", consider renaming to
"CachedAnalysisError".

[Brian Wilkerson, 2016-06-06 20:10:30]

lgtm

[scheglov, 2016-06-06 20:23:52]

I've made some changes.
Brian, could you PTAL?

https://codereview.chromium.org/2042883002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):

https://codereview.chromium.org/2042883002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:327: * Return the
[ErrorCode] reference by the given [error], throws if not found.
On 2016/06/06 20:03:31, Paul Berry wrote:
> s/reference/referenced/

Fixed.

https://codereview.chromium.org/2042883002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:331: for (ErrorCode
errorCode in ErrorCode.values) {
On 2016/06/06 20:03:31, Paul Berry wrote:
> I'm concerned that this is going to wind up being a performance bottleneck,
> since on average it will have to iterate through 50% of all possible errors in
> order to find the matching one.
> 
> Consider doing something like this:
> 
> final Map<String, ErrorCode> _errorCodeMap = _computeErrorCodeMap();
> 
> Map<String, ErrorCode> _computeErrorCodeMap() {
>   for (ErrorCode errorCode in ErrorCode.values) {
>     _errorCodeMap[errorCode.uniqueName] = errorCode;
>   }
> }
> 
> ErrorCode _getErrorCode(CacheAnalysisError error) {
>   String name = '${error.errorCodeClass}.${error.errorCodeField}';
>   ErrorCode errorCode = _errorCodeMap[name];
>   if (errorCode != null) {
>     return errorCode;
>   } else {
>     throw new StateError(...);
>   }
> }

Good idea.
I've added the corresponding API to ErrorCode.

[Paul Berry, 2016-06-06 20:26:23]

lgtm

[Brian Wilkerson, 2016-06-06 20:26:38]

lgtm

[scheglov, 2016-06-06 20:27:28]

Description was changed from

==========
Add put/getSourceErrorsInLibrary to IncrementalCache.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Add put/getSourceErrorsInLibrary to IncrementalCache.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/ed8154a53c2357fde3a5adad90e4509a5ab62e8c
==========

[scheglov, 2016-06-06 20:27:31]

Committed patchset #3 (id:40001) manually as
ed8154a53c2357fde3a5adad90e4509a5ab62e8c (presubmit successful).