Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2042873004: Adds blimp browser tests to run on Chromium.linux. (Closed)

Created:
4 years, 6 months ago by haibinlu
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds blimp browser tests to run on Chromium.linux. BUG=602407 Committed: https://crrev.com/db7e32cad39ac249f1a016d5c3bd0f4ffef765f6 Cr-Commit-Position: refs/heads/master@{#398203}

Patch Set 1 #

Patch Set 2 : Config 10% experiment #

Total comments: 4

Patch Set 3 : Addresses Sergey's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, --1 lines) Patch
A + build/args/bots/chromium.linux/blimp_linux_dbg.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
M infra/config/cq.cfg View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sergey Berezin
https://codereview.chromium.org/2042873004/diff/20001/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/2042873004/diff/20001/infra/config/cq.cfg#newcode45 infra/config/cq.cfg:45: name: "Blimp Linux (dbg)" naming convention for trybots: "blimp_linux_dbg". ...
4 years, 6 months ago (2016-06-06 22:01:35 UTC) #2
haibinlu
PTAL https://codereview.chromium.org/2042873004/diff/20001/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/2042873004/diff/20001/infra/config/cq.cfg#newcode45 infra/config/cq.cfg:45: name: "Blimp Linux (dbg)" On 2016/06/06 22:01:35, Sergey ...
4 years, 6 months ago (2016-06-06 23:07:27 UTC) #4
Sergey Berezin
lgtm
4 years, 6 months ago (2016-06-06 23:20:13 UTC) #5
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-06 23:23:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042873004/40001
4 years, 6 months ago (2016-06-06 23:26:26 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-07 02:28:19 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 02:31:26 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/db7e32cad39ac249f1a016d5c3bd0f4ffef765f6
Cr-Commit-Position: refs/heads/master@{#398203}

Powered by Google App Engine
This is Rietveld 408576698